Skip to content

chore: minor refactoring #2290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2025
Merged

chore: minor refactoring #2290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Microsoft.OpenApi/Validations/ValidationRule.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
/// <param name="item">The object item.</param>
internal abstract void Evaluate(IValidationContext context, object item);

internal ValidationRule(string name)

Check warning on line 32 in src/Microsoft.OpenApi/Validations/ValidationRule.cs

View workflow job for this annotation

GitHub Actions / Build 

Change the visibility of this constructor to 'private protected'. (https://rules.sonarsource.com/csharp/RSPEC-3442)

Check warning on line 32 in src/Microsoft.OpenApi/Validations/ValidationRule.cs

View workflow job for this annotation

GitHub Actions / Build 

Change the visibility of this constructor to 'private protected'. (https://rules.sonarsource.com/csharp/RSPEC-3442)

Check warning on line 32 in src/Microsoft.OpenApi/Validations/ValidationRule.cs

View workflow job for this annotation

GitHub Actions / Build 

Change the visibility of this constructor to 'private protected'. (https://rules.sonarsource.com/csharp/RSPEC-3442)

Check warning on line 32 in src/Microsoft.OpenApi/Validations/ValidationRule.cs

View workflow job for this annotation

GitHub Actions / Build 

Change the visibility of this constructor to 'private protected'. (https://rules.sonarsource.com/csharp/RSPEC-3442)
{
Name = !string.IsNullOrEmpty(name) ? name : throw new ArgumentNullException(nameof(name));
}
Expand Down Expand Up @@ -66,12 +66,11 @@
return;
}

if (item is not T)
if (item is not T typedItem)
{
throw new ArgumentException(string.Format(SRResource.InputItemShouldBeType, typeof(T).FullName));
}

var typedItem = (T)item;
this._validate(context, typedItem);
}
}
Expand Down