Skip to content

ci/performance testing #2304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Apr 11, 2025
Merged

ci/performance testing #2304

merged 32 commits into from
Apr 11, 2025
+1,248 −15

Conversation

baywet
Copy link
Member

@baywet baywet commented Apr 4, 2025

fixes #1971

baywet added 11 commits March 28, 2025 14:20
@baywet
ci: performance project scaffolding
b7cb5f0
@baywet
chore: moves benchmark to dedicated directory
e90dcca 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
chore: commits initial benchmark results
f39bc77 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
ci: adds a comparison project for benchmark results
317e2f6 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
ci: adds benchmark runs and comparison
4ba642c 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
ci: renames empty models tests
41bf122 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
Merge branch 'main' into ci/performance-testing
b82594f
@baywet
chore: refactors to a command structure
1c991f6 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
chore: moves models to a dedicated source file
1cbeab6 
chore: uses STJ attribute based serialization

Signed-off-by: Vincent Biret <[email protected]>
@baywet
ci: fixes missing project argument
a08fc97 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
ci: fixes reports path
a491315 
Signed-off-by: Vincent Biret <[email protected]>
@baywet baywet self-assigned this Apr 4, 2025
baywet added 15 commits April 4, 2025 16:23
@baywet
chore: moves policies to own directory
308b022 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
chore: no warn on static method for perf test project
4671651
@baywet
Merge branch 'main' into ci/performance-testing
be4f841
@baywet
chore: linting
3bc2c97 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
chore: reduces run time for empty performance tests
51c63bb 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
chore: linting
240fb54 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: a bug where the input stream would be disposed not matter what
8b4fd00 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
ci: fixes working directory for benchmark run
b78b847 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
ci: adds basic infrastructure for descriptions based performance tests
93ef172 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
chore: refresh empty object tests
c306a76 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
ci: adds comparison run for descriptions comparisons
ad1a454 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
ci: adds percentage based comparisons
e603b74 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
ci: adds large description to performance tests
9793500 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
ci: adds yaml descriptions perf tests to compare
0a5a07d 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
ci: adds truncation in percentage difference to reduce noise
562b4a3 
Signed-off-by: Vincent Biret <[email protected]>
@baywet baywet marked this pull request as ready for review April 8, 2025 18:07
@baywet baywet requested a review from a team as a code owner April 8, 2025 18:07
@baywet baywet enabled auto-merge (squash) April 8, 2025 18:21
@baywet baywet mentioned this pull request Apr 8, 2025
Merged
@MaggieKimani1
Copy link
Contributor

MaggieKimani1 commented Apr 9, 2025 •
edited
Loading

Is the run comparison tool for empty models CI step supposed to be failing? I see the one for v1 is running successfully.

@baywet
Copy link
Member Author

baywet commented Apr 9, 2025

Is the run comparison tool for empty models CI step supposed to be failing? I see the one for v1 is running successfully.

yes, this is strange, the memory footprint of an OpenAPISchema is not the same on my local machine and on the runners, and I don't know why.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
7.0% Coverage on New Code (required ≥ 80%)
3.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@baywet baywet mentioned this pull request Apr 10, 2025
Merged
@baywet baywet merged commit 63a8a34 into main Apr 11, 2025
16 of 17 checks passed
@baywet baywet deleted the ci/performance-testing branch April 11, 2025 09:02
DevoUmair
DevoUmair reviewed May 14, 2025
View reviewed changes
performance/Program.cs Outdated
using BenchmarkDotNet.Configs;
using BenchmarkDotNet.Running;

namespace performance
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ioj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@DevoUmair DevoUmair DevoUmair left review comments

@MaggieKimani1 MaggieKimani1 MaggieKimani1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@baywet baywet

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[API Review] Memory performance improvements

3 participants

@baywet @MaggieKimani1 @DevoUmair