Skip to content

Conversation

MaggieKimani1
Copy link
Contributor

Fixes #1967

@MaggieKimani1 MaggieKimani1 requested a review from a team as a code owner April 8, 2025 13:13
Copy link

sonarqubecloud bot commented Apr 8, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
78.5% Coverage on New Code (required ≥ 80%)
10.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@MaggieKimani1
Copy link
Contributor Author

@baywet Does this need a squash merge with a conventional commit?

@baywet baywet merged commit ac66756 into main Apr 8, 2025
14 of 15 checks passed
@baywet baywet deleted the fix/max-and-min-types branch April 8, 2025 17:55
@baywet
Copy link
Member

baywet commented Apr 8, 2025

@MaggieKimani1 I usually base that decision on: do I have conventional commits already? how many commits are in this PR? 5 or above... squash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[API Review] Decimal vs Double for Max/Min in OpenAPISchema type

2 participants