Skip to content

ci: adds a point 2 policy to reduce noise #2318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

ci: adds a point 2 policy to reduce noise #2318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ jobs:
OLD_REPORT: "${{ github.workspace }}/performanceResults/performance.EmptyModels-report.json"

- name: Run comparison tool for descriptions
run: dotnet run -c Release --project ./performance/resultsComparer/resultsComparer.csproj -- compare $OLD_REPORT $NEW_REPORT -p ZeroPointOnePercentDifferenceMemoryUsage
run: dotnet run -c Release --project ./performance/resultsComparer/resultsComparer.csproj -- compare $OLD_REPORT $NEW_REPORT -p ZeroPointTwoPercentDifferenceMemoryUsage
shell: bash
env:
NEW_REPORT: "${{ github.workspace }}/performance/benchmark/BenchmarkDotNet.Artifacts/results/performance.Descriptions-report.json"
Expand Down
1 change: 1 addition & 0 deletions performance/resultsComparer/policies/IBenchmarkComparisonPolicy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ public static IBenchmarkComparisonPolicy[] GetAllPolicies()
return [
IdenticalMemoryUsagePolicy.Instance,
ZeroPointOnePercentDifferenceMemoryUsagePolicy.Instance,
ZeroPointTwoPercentDifferenceMemoryUsagePolicy.Instance,
OnePercentDifferenceMemoryUsagePolicy.Instance,
TwoPercentDifferenceMemoryUsagePolicy.Instance,
FivePercentDifferenceMemoryUsagePolicy.Instance,
Expand Down
7 changes: 7 additions & 0 deletions performance/resultsComparer/policies/PercentageMemoryUsagePolicy.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,13 @@
public ZeroPointOnePercentDifferenceMemoryUsagePolicy():base(0.1f) {}
}

internal sealed class ZeroPointTwoPercentDifferenceMemoryUsagePolicy : PercentageMemoryUsagePolicy
{
public static ZeroPointTwoPercentDifferenceMemoryUsagePolicy Instance { get; } = new ZeroPointTwoPercentDifferenceMemoryUsagePolicy();
protected override string TypeName => nameof(ZeroPointTwoPercentDifferenceMemoryUsagePolicy);
public ZeroPointTwoPercentDifferenceMemoryUsagePolicy():base(0.2f) {}
}

internal sealed class OnePercentDifferenceMemoryUsagePolicy : PercentageMemoryUsagePolicy
{
public static OnePercentDifferenceMemoryUsagePolicy Instance { get; } = new OnePercentDifferenceMemoryUsagePolicy();
Expand Down Expand Up @@ -44,7 +51,7 @@
return false;
}
var forwardRatio = GetPercentageDifference(x, y);
var backwardRatio = GetPercentageDifference(y, x);

Check warning on line 54 in performance/resultsComparer/policies/PercentageMemoryUsagePolicy.cs

View workflow job for this annotation

GitHub Actions / Build 

Parameters to 'GetPercentageDifference' have the same names but not the same order as the method arguments. (https://rules.sonarsource.com/csharp/RSPEC-2234)
return forwardRatio <= TolerancePercentagePoints && backwardRatio <= TolerancePercentagePoints;
}
private static double GetPercentageDifference(BenchmarkMemory x, BenchmarkMemory y)
Expand Down
Loading