Skip to content

Use SHA512.HashDataAsync #2324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2025
Merged

Use SHA512.HashDataAsync #2324

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ca8ae3
Use SHA512.HashDataAsync
martincostello Apr 14, 2025
5b5bac9
Apply suggestions from code review
baywet Apr 14, 2025
69051c8
chore: uses 31 serialization method
baywet Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 22 additions & 7 deletions src/Microsoft.OpenApi/Models/OpenApiDocument.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,20 +524,35 @@ public void SetReferenceHostDocument()
/// <returns>The hash value.</returns>
public async Task<string> GetHashCodeAsync(CancellationToken cancellationToken = default)
{
#if NET7_OR_GREATER
using var memoryStream = new MemoryStream();
using var streamWriter = new StreamWriter(memoryStream);

await WriteDocumentAsync(streamWriter, cancellationToken).ConfigureAwait(false);

memoryStream.Seek(0, SeekOrigin.Begin);

var hash = await SHA512.HashDataAsync(memoryStream, cancellationToken).ConfigureAwait(false);
#else
using HashAlgorithm sha = SHA512.Create();
using var cryptoStream = new CryptoStream(Stream.Null, sha, CryptoStreamMode.Write);
using var streamWriter = new StreamWriter(cryptoStream);

var openApiJsonWriter = new OpenApiJsonWriter(streamWriter, new() { Terse = true });
SerializeAsV3(openApiJsonWriter);
await openApiJsonWriter.FlushAsync(cancellationToken).ConfigureAwait(false);
await WriteDocumentAsync(streamWriter, cancellationToken).ConfigureAwait(false);

#if NET5_0_OR_GREATER
await cryptoStream.FlushFinalBlockAsync(cancellationToken).ConfigureAwait(false);
#else
cryptoStream.FlushFinalBlock();

var hash = sha.Hash;
#endif
return ConvertByteArrayToString(sha.Hash ?? []);

return ConvertByteArrayToString(hash ?? []);

async Task WriteDocumentAsync(TextWriter writer, CancellationToken token)
{
var openApiJsonWriter = new OpenApiJsonWriter(writer, new() { Terse = true });
SerializeAsV31(openApiJsonWriter);
await openApiJsonWriter.FlushAsync(cancellationToken).ConfigureAwait(false);
}
}

private static string ConvertByteArrayToString(byte[] hash)
Expand Down