Skip to content

chore: implement tests for routing issues during serialization #2340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 14, 2025
Merged

chore: implement tests for routing issues during serialization #2340

merged 5 commits into from
May 14, 2025

Conversation

@MaggieKimani1
Copy link
Contributor

@MaggieKimani1 MaggieKimani1 commented Apr 28, 2025 •
edited
Loading

Uses spies in Moq to inspect and record the sequence in which serialization methods are called in the model classes during routing.

Fixes #2081

@MaggieKimani1 MaggieKimani1 requested a review from a team as a code owner April 28, 2025 14:39
@MaggieKimani1 MaggieKimani1 changed the title feat: implement tests for routing issues during serialization chore: implement tests for routing issues during serialization Apr 28, 2025
@MaggieKimani1 MaggieKimani1 enabled auto-merge April 29, 2025 09:12
@MaggieKimani1
Copy link
Contributor Author

MaggieKimani1 commented May 13, 2025

@baywet can I get a review on this?

baywet
baywet reviewed May 13, 2025
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great work! I thought we'd be able to implement only 3 tests and somehow setup the mocks generically, but this will do for now.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 13, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

baywet
baywet approved these changes May 14, 2025
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@MaggieKimani1 MaggieKimani1 merged commit e2cd111 into main May 14, 2025
19 of 20 checks passed
@MaggieKimani1 MaggieKimani1 deleted the chore/implement-tests-for-routing-issues branch May 14, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darrelmiller darrelmiller darrelmiller left review comments

@baywet baywet baywet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

v2 - implement tests for routing issues

4 participants

@MaggieKimani1 @darrelmiller @baywet