-
Notifications
You must be signed in to change notification settings - Fork 7.7k
[WIP]C# Runner and overall reduction of code complexity #43714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check-spelling found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…olHook and NativeKeyboardHelper to ManagedCommon
…d fix bug report running message
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.Unrecognized words (41)These words are not needed and should be removedBitmaps BLACKFRAME BUILDNUMBER CMDNOTFOUNDMODULEINTERFACE CONFIGW displayname Dlg dwl DWORDLONG examplepowertoy explr FILEEXPLORER HDEVNOTIFY HIDEREADONLY LIBID LOGFONT LONGNAMES LPCFHOOKPROC LPQUERY LPTR MSIDXS MSIDXSPROP NOTIFYICONDATA OSVERSIONINFOEX osvi POWERDISPLAYMODULEINTERFACE POWERTOYNAME prevpane projectname Propset prvpane REGISTRYPREVIEWEXT ROWSETEXT safeprojectname settingsheader sttngs templatenamespace uncompilable vstemplate WCT WHEREID WIL WINTHRESHOLDSome files were automatically ignored 🙈These sample patterns would exclude them: You should consider adding them to: File matching is via Perl regular expressions. To check these files, more of their words need to be in the dictionary than not. You can use To accept these unrecognized words as correct, update file exclusions, and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the [email protected]:microsoft/PowerToys.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/c635c2f3f714eec2fcf27b643a1919b9a811ef2e/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/21683777055/attempts/1' &&
git commit -m 'Update check-spelling metadata'Errors and Warnings ❌ (3)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See ❌ Event descriptions for more information. If the flagged items are 🤯 false positivesIf items relate to a ...
|
Summary of the Pull Request
Changes
AdditionalActionpipe command to use id rather then textHotkeySettingsControlHookandNativeKeyboardHelpertoManagedCommonfromPowerToys.SettingsLogger.InitializeLoggernow clears all previous listenersGenerated Files\version_gen.htoCpp.build.propsnotifications::disable_toast()to c# into the runner to the newNotificationHelperclassutils/package.hhere and added Package class.Ported
Functionalities
Modules
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed