Skip to content

CmdPal: Refactoring DI, Logging, and Extension Services #45437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
michaeljolley wants to merge 19 commits into
base: main
Choose a base branch
from
+3,770 −2,473
Draft

CmdPal: Refactoring DI, Logging, and Extension Services #45437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
5f273c7
Rename Microsoft.CmdPal.Core.Common to Microsoft.CmdPal.Common
michaeljolley Jan 26, 2026
ba9585a
Migrate Microsoft.CmdPal.Core.ViewModels into Microsoft.CmdPal.UI.Vie…
michaeljolley Jan 26, 2026
b5ae2ef
Rename CoreLogger to CmdPalLogger
michaeljolley Jan 26, 2026
81aeb74
Use ILogger in AppExtensionHost instead of CoreLogger
michaeljolley Jan 26, 2026
a1e8b6a
Add AppStateService and SettingsService with PersistenceService
michaeljolley Jan 27, 2026
f78ec0c
Migrate CoreLogger to ILogger with LoggerMessage pattern (partial)
michaeljolley Jan 27, 2026
ec42317
Refactor CmdPal to inject SettingsService instead of SettingsModel
michaeljolley Jan 27, 2026
303be86
Working on DI
michaeljolley Jan 28, 2026
fa4bc0a
Working on DI
michaeljolley Jan 30, 2026
94a699d
Working on DI
michaeljolley Jan 31, 2026
54c5d7b
Working on DI
michaeljolley Feb 3, 2026
10f953f
Working on DI
michaeljolley Feb 3, 2026
d3d39f9
DI
michaeljolley Feb 4, 2026
2851838
I don't know what I've done. Send help... or Jiri
michaeljolley Feb 4, 2026
99a6c8c
Working on DI
michaeljolley Feb 5, 2026
8267166
WinRTExtensionService
michaeljolley Feb 9, 2026
54d1ab3
WinRTExtensionService
michaeljolley Feb 11, 2026
12bfa13
Fixing spelling
michaeljolley Feb 11, 2026
c7f8ac0
Merging main (broken)
michaeljolley Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions PowerToys.slnx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,10 @@
<Folder Name="/modules/CommandPalette/">
<Project Path="src/modules/cmdpal/CmdPalKeyboardService/CmdPalKeyboardService.vcxproj" Id="5f63c743-f6ce-4dba-a200-2b3f8a14e8c2" />
<Project Path="src/modules/cmdpal/CmdPalModuleInterface/CmdPalModuleInterface.vcxproj" Id="0adeb797-c8c7-4ffa-acd5-2af6cad7ecd8" />
<Project Path="src/modules/cmdpal/Microsoft.CmdPal.Common/Microsoft.CmdPal.Common.csproj">
<Platform Solution="*|ARM64" Project="ARM64" />
<Platform Solution="*|x64" Project="x64" />
</Project>
</Folder>
<Folder Name="/modules/CommandPalette/Built-in Extensions/">
<Project Path="src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.Apps/Microsoft.CmdPal.Ext.Apps.csproj">
Expand Down Expand Up @@ -275,16 +279,6 @@
<Deploy />
</Project>
</Folder>
<Folder Name="/modules/CommandPalette/Core/">
<Project Path="src/modules/cmdpal/Core/Microsoft.CmdPal.Core.Common/Microsoft.CmdPal.Core.Common.csproj">
<Platform Solution="*|ARM64" Project="ARM64" />
<Platform Solution="*|x64" Project="x64" />
</Project>
<Project Path="src/modules/cmdpal/Core/Microsoft.CmdPal.Core.ViewModels/Microsoft.CmdPal.Core.ViewModels.csproj">
<Platform Solution="*|ARM64" Project="ARM64" />
<Platform Solution="*|x64" Project="x64" />
</Project>
</Folder>
<Folder Name="/modules/CommandPalette/Extension SDK/">
<Project Path="src/modules/cmdpal/extensionsdk/Microsoft.CommandPalette.Extensions.Toolkit/Microsoft.CommandPalette.Extensions.Toolkit.csproj">
<Platform Solution="*|ARM64" Project="ARM64" />
Expand Down
3 changes: 1 addition & 2 deletions src/modules/cmdpal/CommandPalette.slnf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@
"src\\common\\version\\version.vcxproj",
"src\\modules\\cmdpal\\CmdPalKeyboardService\\CmdPalKeyboardService.vcxproj",
"src\\modules\\cmdpal\\CmdPalModuleInterface\\CmdPalModuleInterface.vcxproj",
"src\\modules\\cmdpal\\Core\\Microsoft.CmdPal.Core.Common\\Microsoft.CmdPal.Core.Common.csproj",
"src\\modules\\cmdpal\\Core\\Microsoft.CmdPal.Core.ViewModels\\Microsoft.CmdPal.Core.ViewModels.csproj",
"src\\modules\\cmdpal\\Microsoft.CmdPal.Common\\Microsoft.CmdPal.Common.csproj",
"src\\modules\\cmdpal\\Microsoft.CmdPal.UI.ViewModels\\Microsoft.CmdPal.UI.ViewModels.csproj",
"src\\modules\\cmdpal\\Microsoft.CmdPal.UI\\Microsoft.CmdPal.UI.csproj",
"src\\modules\\cmdpal\\Microsoft.Terminal.UI\\Microsoft.Terminal.UI.vcxproj",
Expand Down
62 changes: 0 additions & 62 deletions src/modules/cmdpal/Core/Microsoft.CmdPal.Core.Common/CoreLogger.cs
View file
Open in desktop

This file was deleted.

26 changes: 0 additions & 26 deletions src/modules/cmdpal/Core/Microsoft.CmdPal.Core.Common/Microsoft.CmdPal.Core.Common.csproj
View file
Open in desktop

This file was deleted.

37 changes: 0 additions & 37 deletions src/modules/cmdpal/Core/Microsoft.CmdPal.Core.Common/Services/IExtensionService.cs
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions src/modules/cmdpal/Core/Microsoft.CmdPal.Core.ViewModels/AsyncNavigationRequest.cs
View file
Open in desktop

This file was deleted.

25 changes: 0 additions & 25 deletions ...ules/cmdpal/Core/Microsoft.CmdPal.Core.ViewModels/Microsoft.CmdPal.Core.ViewModels.csproj
View file
Open in desktop

This file was deleted.

72 changes: 0 additions & 72 deletions src/modules/cmdpal/Core/Microsoft.CmdPal.Core.ViewModels/Properties/Resources.Designer.cs
View file
Open in desktop

This file was deleted.

Loading
Loading