Improve an unclear exception message when parameter names are not valid identifiers#7862
Open
michaelstoops wants to merge 1 commit intomicrosoft:mainfrom
Open
Improve an unclear exception message when parameter names are not valid identifiers#7862michaelstoops wants to merge 1 commit intomicrosoft:mainfrom
michaelstoops wants to merge 1 commit intomicrosoft:mainfrom
Conversation
I made it more clear.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7862 +/- ##
==========================================
+ Coverage 59.87% 59.94% +0.07%
==========================================
Files 352 352
Lines 31872 31932 +60
==========================================
+ Hits 19083 19142 +59
- Misses 12789 12790 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
Thanks @michaelstoops In the future I would recommend pr titles that descript the change rather than the issue. E.g. something like |
Contributor
Author
|
Fair point, @jenshnielsen. I've adjusted this PR. I was going to add some guidance to CONTRIBUTING.rst. I see that the existing text suggests the use of a template. What template does it mean? Michael |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an unclear exception message in parameter_base.py.
I made it more clear.