Skip to content

Improve an unclear exception message when parameter names are not valid identifiers#7862

Open
michaelstoops wants to merge 1 commit intomicrosoft:mainfrom
michaelstoops:parameter_base/exception
Open

Improve an unclear exception message when parameter names are not valid identifiers#7862
michaelstoops wants to merge 1 commit intomicrosoft:mainfrom
michaelstoops:parameter_base/exception

Conversation

@michaelstoops
Copy link
Contributor

There was an unclear exception message in parameter_base.py.

I made it more clear.

@michaelstoops michaelstoops requested a review from a team as a code owner February 13, 2026 00:41
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.94%. Comparing base (df22e8a) to head (b6f5697).
⚠️ Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7862      +/-   ##
==========================================
+ Coverage   59.87%   59.94%   +0.07%     
==========================================
  Files         352      352              
  Lines       31872    31932      +60     
==========================================
+ Hits        19083    19142      +59     
- Misses      12789    12790       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jenshnielsen
Copy link
Collaborator

Thanks @michaelstoops

In the future I would recommend pr titles that descript the change rather than the issue. E.g. something like Improve error message when parameter name is not a valid identifier

@michaelstoops michaelstoops changed the title There was an unclear exception message in parameter_base.py. Improve an unclear exception message when parameter names are not valid identifiers Feb 13, 2026
@michaelstoops
Copy link
Contributor Author

Fair point, @jenshnielsen. I've adjusted this PR.

I was going to add some guidance to CONTRIBUTING.rst. I see that the existing text suggests the use of a template.

The template will help you write nice pull requests <3 !

What template does it mean?

Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants