Skip to content

Fix spelling errors and incorrect property assignments in SdnDiag.Server.psm1 #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arudell merged 4 commits into from
Jan 26, 2026
Merged

Fix spelling errors and incorrect property assignments in SdnDiag.Server.psm1 #528

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4321d9
Initial plan
Copilot Dec 31, 2025
c134cf9
Fix spelling errors and incorrect property assignments in SdnDiag.Ser…
Copilot Dec 31, 2025
be6f7a9
Fix remaining OffloadState property assignments in Get-SdnVfpPortState
Copilot Jan 26, 2026
6127573
Merge branch 'main' of https://github.com/microsoft/SdnDiagnostics in…
arudell Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions src/modules/SdnDiag.Server.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ function Get-ServerConfigState {
vfpctrl /list-nat-range /port $($port.Name) | Export-ObjectToFile -FilePath $outputDir.FullName -Prefix $port.Name -Name 'vfpctrl_list_nat_range' -FileType txt -Force
vfpctrl /list-rule /port $($port.Name) | Export-ObjectToFile -FilePath $outputDir.FullName -Prefix $port.Name -Name 'vfpctrl_list_rule' -FileType txt -Force
vfpctrl /list-mapping /port $($port.Name) | Export-ObjectToFile -FilePath $outputDir.FullName -Prefix $port.Name -Name 'vfpctrl_list_mapping' -FileType txt -Force
vfpctrl /list-unified-flow /port $port.Name | Export-ObjectToFile -FilePath $outputDir.FullName -Prefix $port.Name -Name 'vfpctrl_list_unifiied_flow' -FileType txt -Force
vfpctrl /list-unified-flow /port $port.Name | Export-ObjectToFile -FilePath $outputDir.FullName -Prefix $port.Name -Name 'vfpctrl_list_unified_flow' -FileType txt -Force
vfpctrl /get-port-flow-settings /port $($port.Name) | Export-ObjectToFile -FilePath $outputDir.FullName -Prefix $port.Name -Name 'vfpctrl_get_port_flow_settings' -FileType txt -Force
vfpctrl /get-port-flow-stats /port $($port.Name) | Export-ObjectToFile -FilePath $outputDir.FullName -Prefix $port.Name -Name 'vfpctrl_get_port_flow_stats' -FileType txt -Force
vfpctrl /get-flow-stats /port $($port.Name) | Export-ObjectToFile -FilePath $outputDir.FullName -Prefix $port.Name -Name 'vfpctrl_get_flow_stats' -FileType txt -Force
Expand Down Expand Up @@ -2236,17 +2236,17 @@ function Get-SdnVfpPortState {
'VM Context Set' { $object.IsVmContextSet = $propertyValue }

# update the OffLoadStateDetails properties
'NVGRE LSO Offload Enabled' { $object.PortState.LsoV2Supported = $propertyValue}
'NVGRE RSS Enabled' { $object.PortState.RssSupported = $propertyValue }
'NVGRE Transmit Checksum Offload Enabled' { $object.PortState.TransmitChecksumOffloadSupported = $propertyValue }
'NVGRE Receive Checksum Offload Enabled' { $object.PortState.ReceiveChecksumOffloadSupported = $propertyValue }
'NVGRE VMQ Enabled' { $object.PortState.VmqSupported = $propertyValue }
'VXLAN LSO Offload Enabled' { $object.PortState.LsoV2SupportedVxlan = $propertyValue }
'VXLAN RSS Enabled' { $object.PortState.RssSupportedVxlan = $propertyValue }
'VXLAN Transmit Checksum Offload Enabled' { $object.PortState.TransmitChecksumOffloadSupportedVxlan = $propertyValue }
'VXLAN Receive Checksum Offload Enabled' { $object.PortState.ReceiveChecksumOffloadSupportedVxlan = $propertyValue }
'VXLAN VMQ Enabled' { $object.PortState.VmqSupportedVxlan = $propertyValue }
'Inner MAC VMQ Enabled' { $object.PortState.InnerMacVmqEnabled = $propertyValue }
'NVGRE LSO Offload Enabled' { $object.OffloadState.LsoV2Supported = $propertyValue}
'NVGRE RSS Enabled' { $object.OffloadState.RssSupported = $propertyValue }
'NVGRE Transmit Checksum Offload Enabled' { $object.OffloadState.TransmitChecksumOffloadSupported = $propertyValue }
'NVGRE Receive Checksum Offload Enabled' { $object.OffloadState.ReceiveChecksumOffloadSupported = $propertyValue }
'NVGRE VMQ Enabled' { $object.OffloadState.VmqSupported = $propertyValue }
'VXLAN LSO Offload Enabled' { $object.OffloadState.LsoV2SupportedVxlan = $propertyValue }
'VXLAN RSS Enabled' { $object.OffloadState.RssSupportedVxlan = $propertyValue }
'VXLAN Transmit Checksum Offload Enabled' { $object.OffloadState.TransmitChecksumOffloadSupportedVxlan = $propertyValue }
'VXLAN Receive Checksum Offload Enabled' { $object.OffloadState.ReceiveChecksumOffloadSupportedVxlan = $propertyValue }
'VXLAN VMQ Enabled' { $object.OffloadState.VmqSupportedVxlan = $propertyValue }
'Inner MAC VMQ Enabled' { $object.OffloadState.InnerMacVmqEnabled = $propertyValue }

default {
$propertyName = $propertyName.Replace(' ','').Trim()
Expand Down Expand Up @@ -2426,7 +2426,7 @@ function Get-SdnVfpVmSwitchPort {
'Packets Sent' { $object.VmNicStatistics.PacketsSent = $value }
'Packets Received' { $object.VmNicStatistics.PacketsReceived = $value }
'Interrupts Received' { $object.VmNicStatistics.InterruptsReceived = $value }
'Send Buffer Allocation Count' { $object.VmNicStatistics.SendBufferAllocationSize = $value }
'Send Buffer Allocation Count' { $object.VmNicStatistics.SendBufferAllocationCount = $value }
'Send Buffer Allocation Size' { $object.VmNicStatistics.SendBufferAllocationSize = $value }
'Receive Buffer Allocation Count' { $object.VmNicStatistics.ReceiveBufferAllocationCount = $value }
'Receive Buffer Allocation Size' { $object.VmNicStatistics.ReceiveBufferAllocationSize = $value }
Expand All @@ -2435,8 +2435,8 @@ function Get-SdnVfpVmSwitchPort {
'Pending Routed Packets' { $object.VmNicStatistics.PendingRoutedPackets = $value }
'Insufficient Receive Buffers' { $object.VmNicStatistics.InsufficientReceiveBuffers = $value }
'Insufficient Send Buffers' { $object.VmNicStatistics.InsufficientSendBuffers = $value }
'Insufficient RNDIS Operations Buffers' { $object.VmNicStatistics.InsufficientRndisOperationsBuffers = $value }
'Quota Exceeded Errors' { $object.VmNicStatistics.QuotaExceededErrors = $value }
'Insufficient RNDIS Operations Buffers' { $object.VmNicStatistics.InsufficientRndisOperations = $value }
'Quota Exceeded Errors' { $object.VmNicStatistics.QuotaExceeded = $value }
'Vsp Paused' { $object.VmNicStatistics.VspPaused = $value }

# most of the property names, we can just trim and remove the white spaces
Expand Down