Skip to content

Conversation

@liqul
Copy link
Collaborator

@liqul liqul commented Jan 13, 2025

No description provided.

@liqul liqul requested a review from Copilot January 13, 2025 11:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 10 changed files in this pull request and generated no comments.

Files not reviewed (4)
  • README.md: Evaluated as low risk
  • taskweaver/memory/attachment.py: Evaluated as low risk
  • project/examples/planner_examples/example-planner-2.yaml: Evaluated as low risk
  • project/examples/planner_examples/example-planner-echo.yaml: Evaluated as low risk
Comments suppressed due to low confidence (2)

taskweaver/ext_role/recepta/recepta.role.yaml:3

  • [nitpick] The term 'intro' should be renamed to 'description' for better clarity.
intro : |-

taskweaver/ext_role/recepta/recepta.role.yaml:6

  • [nitpick] The sentence could be clearer. Suggested: 'When Planner needs to reason in the middle of the task and is not ready to talk to the User, it can send a message to Recepta to record the reasoning process and result.'
When Planner needs to reason in the middle of the task and it is not ready to talk to the User, it can send a message to `Recepta` to record the process and result.

@liqul liqul changed the title Add Recepta Role for CoT in Planner Add Recepta Role for CoT in Planner [Not ready] Jan 13, 2025
@liqul liqul changed the title Add Recepta Role for CoT in Planner [Not ready] Add Recepta Role for CoT in Planner [Ready] Jan 16, 2025
@liqul liqul requested review from ShilinHe and Copilot January 16, 2025 09:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 12 changed files in this pull request and generated no comments.

Files not reviewed (5)
  • project/examples/planner_examples/example-planner.yaml: Evaluated as low risk
  • taskweaver/ces/runtime/executor.py: Evaluated as low risk
  • taskweaver/ext_role/recepta/recepta.py: Evaluated as low risk
  • taskweaver/ext_role/recepta/recepta.role.yaml: Evaluated as low risk
  • taskweaver/memory/attachment.py: Evaluated as low risk
Comments suppressed due to low confidence (5)

project/examples/planner_examples/example-planner-recepta.yaml:54

  • [nitpick] The phrase 'interactively depends on' is unclear. Consider rephrasing to 'depends on the completion of step 1'.
2. validate the role <interactively depends on 1>

project/examples/planner_examples/example-planner-recepta.yaml:55

  • [nitpick] The phrase 'interactively depends on' is unclear. Consider rephrasing to 'depends on the completion of step 1'.
3. construct and print the SQL query using the extracted details <interactively depends on 1>

project/examples/planner_examples/example-planner-recepta.yaml:56

  • [nitpick] The phrase 'interactively depends on' is unclear. Consider rephrasing to 'depends on the completion of steps 1 and 3'.
4. check the execution result and report the result to the user <interactively depends on 1 and 3>

taskweaver/planner/planner_prompt.yaml:147

  • The renaming of 'reasoning' to 'plan_reasoning' should be checked for consistency across the entire codebase.
"plan_reasoning": {

taskweaver/planner/planner_prompt.yaml:166

  • The description for the 'stop' field should be clear and consistent. Consider rephrasing to 'The reason for stopping the Planner. Set to 'InProcess' if the Planner is not talking to the User.'
"enum": ["InProcess", "Completed", "Clarification", "AdditionalInformation", "SecurityRisks", "TaskFailure"]

@liqul liqul merged commit 724c37a into main Jan 20, 2025
2 checks passed
@liqul liqul deleted the liqun/opt_planner_reasoning branch January 20, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants