optimized reflection caching

Author: markusheiliger

src/TeamCloud.Data/IDocumentSubscription.cs

@@ -4,19 +4,36 @@
  */
 
 using System;
+using System.Collections.Concurrent;
+using System.Reflection;
 using System.Threading.Tasks;
 using TeamCloud.Model.Data.Core;
 
 namespace TeamCloud.Data;
 
 public abstract class DocumentSubscription : IDocumentSubscription
 {
+    private static readonly ConcurrentDictionary<Type, ConcurrentDictionary<Type, MethodInfo>> HandleMethodCache = new ConcurrentDictionary<Type,ConcurrentDictionary<Type, MethodInfo>>();
+
+    private MethodInfo GetHandleMethod(IContainerDocument containerDocument) => HandleMethodCache
+        .GetOrAdd(GetType(), _ => new ConcurrentDictionary<Type, MethodInfo>())
+        .GetOrAdd(containerDocument.GetType(), containerDocumentType =>
+        {
+            var subscriberInterface = typeof(IDocumentSubscription<>)
+                .MakeGenericType(containerDocument.GetType());
+
+            if (subscriberInterface.IsAssignableFrom(GetType()))
+                return subscriberInterface.GetMethod(nameof(HandleAsync), new Type[] { containerDocument.GetType(), typeof(DocumentSubscriptionEvent) });
+
+            return null;
+        });
+
     public virtual bool CanHandle(IContainerDocument containerDocument)
     {
         if (containerDocument is null)
             throw new ArgumentNullException(nameof(containerDocument));
 
-        return typeof(IDocumentSubscription<>).MakeGenericType(containerDocument.GetType()).IsAssignableFrom(GetType());
+        return GetHandleMethod(containerDocument) is not null;
     }
 
     public virtual Task HandleAsync(IContainerDocument containerDocument, DocumentSubscriptionEvent subscriptionEvent)
@@ -25,12 +42,7 @@ public virtual Task HandleAsync(IContainerDocument containerDocument, DocumentSu
             throw new ArgumentNullException(nameof(containerDocument));
 
         if (CanHandle(containerDocument))
-        {
-            return (Task)typeof(IDocumentExpander<>)
-                .MakeGenericType(containerDocument.GetType())
-                .GetMethod(nameof(HandleAsync), new Type[] { containerDocument.GetType(), typeof(DocumentSubscriptionEvent) })
-                .Invoke(this, new object[] { containerDocument, subscriptionEvent });
-        }
+            return (Task)GetHandleMethod(containerDocument).Invoke(this, new object[] { containerDocument, subscriptionEvent });
 
         throw new NotImplementedException($"Missing document subscription implementation IDocumentSubscription<{containerDocument.GetType().Name}> at {GetType()}");
     }

src/TeamCloud.Orchestrator/Command/CommandHandler.cs

@@ -27,7 +27,7 @@ public abstract class CommandHandler : ICommandHandler
     private static readonly ConcurrentDictionary<Type, ConcurrentDictionary<Type, MethodInfo>> HandleMethodCache = new ConcurrentDictionary<Type, ConcurrentDictionary<Type, MethodInfo>>();
 
     private MethodInfo GetHandleMethod(ICommand command) => HandleMethodCache
-        .GetOrAdd(GetType(), handlerType => new ConcurrentDictionary<Type, MethodInfo>())
+        .GetOrAdd(GetType(), _ => new ConcurrentDictionary<Type, MethodInfo>())
         .GetOrAdd(command.GetType(), commandType =>
     {
         var handlerInterface = typeof(ICommandHandler<>)
@@ -58,10 +58,7 @@ public virtual Task<ICommandResult> HandleAsync(ICommand command, IAsyncCollecto
             throw new ArgumentNullException(nameof(command));
 
         if (CanHandle(command))
-        {
-            return (Task<ICommandResult>)GetHandleMethod(command)
-                .Invoke(this, new object[] { command, commandQueue, orchestrationContext, log });
-        }
+            return (Task<ICommandResult>)GetHandleMethod(command).Invoke(this, new object[] { command, commandQueue, orchestrationContext, log });
 
         throw new NotImplementedException($"Missing orchestrator command handler implementation ICommandHandler<{command.GetTypeName(prettyPrint: true)}> at {GetType()}");
     }