Fix TypeError in debug logging when data contains sets #141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where
TinyPersonFactorycrashes with aTypeErrorwhen logging level is set toINFOorDEBUGinconfig.ini. ( Issue: #140 )Error message:
Root Cause
The issue occurs in 4 locations in
tiny_person_factory.pywherejson.dumps()is used for debug logging:generate_person(): Generated person parameters_initialize_sampling_plan_transaction(): Sampling dimensions_initialize_sampling_plan_transaction(): Sampling plan_initialize_sampling_plan_transaction(): Remaining characteristics sampleAll of these data structures may contain Python
setobjects (likely used for deduplication/uniqueness), which are not JSON serializable by default.Changes
Added:
_safe_json_dumps()helper function (after line 21). This function convertssetobjects tolistbefore serialization, preserving the debug output while avoiding the crash.Modified (4 locations):
generate_person()- Use_safe_json_dumps()for person parameters_initialize_sampling_plan_transaction()- Use_safe_json_dumps()for sampling dimensions_initialize_sampling_plan_transaction()- Use_safe_json_dumps()for sampling plan_initialize_sampling_plan_transaction()- Use_safe_json_dumps()for remaining characteristics