Skip to content

Implement ResponseConstructor to allow overrides from other runtimes #1941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Implement ResponseConstructor to allow overrides from other runtimes #1941

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d37a7b4
Implement ResponseConstructor
alii Mar 15, 2025
1da1aae
Remove properties that have defaults
alii Mar 15, 2025
060ddd1
accept baselines
alii Mar 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
234 changes: 234 additions & 0 deletions inputfiles/addedTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,6 +454,227 @@
},
"interfaces": {
"interface": {
"Response": {
"name": "Response",
"noInterfaceObject": true,

"properties": {
"property": {
"type": {
"name": "type",
"type": "ResponseType",
"readonly": true,
"exposed": "Window Worker",
"mdnUrl": "https://developer.mozilla.org/docs/Web/API/Response/type"
},
"url": {
"name": "url",
"type": "USVString",
"readonly": true,
"exposed": "Window Worker",
"mdnUrl": "https://developer.mozilla.org/docs/Web/API/Response/url"
},
"redirected": {
"name": "redirected",
"type": "boolean",
"readonly": true,
"exposed": "Window Worker",
"mdnUrl": "https://developer.mozilla.org/docs/Web/API/Response/redirected"
},
"status": {
"name": "status",
"type": "unsigned short",
"readonly": true,
"exposed": "Window Worker",
"mdnUrl": "https://developer.mozilla.org/docs/Web/API/Response/status"
},
"ok": {
"name": "ok",
"type": "boolean",
"readonly": true,
"exposed": "Window Worker",
"mdnUrl": "https://developer.mozilla.org/docs/Web/API/Response/ok"
},
"statusText": {
"name": "statusText",
"type": "ByteString",
"readonly": true,
"exposed": "Window Worker",
"mdnUrl": "https://developer.mozilla.org/docs/Web/API/Response/statusText"
},
"headers": {
"name": "headers",
"type": "Headers",
"readonly": true,
"exposed": "Window Worker",
"mdnUrl": "https://developer.mozilla.org/docs/Web/API/Response/headers"
}
},
"namesakes": {}
},
"constructor": {
"signature": [
{
"type": "Response",
"param": [
{
"name": "body",
"type": "BodyInit",
"nullable": true,
"optional": true,
"variadic": false
},
{
"name": "init",
"type": "ResponseInit",
"nullable": false,
"optional": true,
"variadic": false
}
]
}
]
},
"exposed": "Window Worker",
"legacyWindowAlias": [],
"secureContext": false,
"transferable": false,
"implements": ["Body"],
"mdnUrl": "https://developer.mozilla.org/docs/Web/API/Response",
"comment": "This Fetch API interface represents the response to a request."
},
"ResponseConstructor": {
"name": "ResponseConstructor",
"noInterfaceObject": true,

"properties": {
"property": {
"prototype": {
"name": "prototype",
"type": "Response",
"exposed": "Window Worker"
}
}
},

"methods": {
"method": {
"new": {
"mdnUrl": "https://developer.mozilla.org/docs/Web/API/Response/Response",
"name": "new",
"exposed": "Window Worker",
"signature": [
{
"type": "Response",
"param": [
{
"name": "body",
"type": "BodyInit",
"nullable": true,
"optional": true,
"variadic": false
},
{
"name": "init",
"type": "ResponseInit",
"nullable": false,
"optional": true,
"variadic": false
}
]
}
]
},
"error": {
"name": "error",
"signature": [
{
"type": "Response",
"nullable": false,
"param": []
}
],
"getter": false,
"stringifier": false,
"exposed": "Window Worker",
"mdnUrl": "https://developer.mozilla.org/docs/Web/API/Response/error_static"
},
"redirect": {
"name": "redirect",
"signature": [
{
"type": "Response",
"nullable": false,
"param": [
{
"name": "url",
"type": "USVString",
"nullable": false,
"optional": false,
"variadic": false
},
{
"name": "status",
"type": "unsigned short",
"nullable": false,
"optional": true,
"variadic": false
}
]
}
],
"getter": false,
"stringifier": false,
"exposed": "Window Worker",
"mdnUrl": "https://developer.mozilla.org/docs/Web/API/Response/redirect_static"
},
"json": {
"name": "json",
"signature": [
{
"type": "Response",
"nullable": false,
"param": [
{
"name": "data",
"type": "any",
"nullable": false,
"optional": false,
"variadic": false
},
{
"name": "init",
"type": "ResponseInit",
"nullable": false,
"optional": true,
"variadic": false
}
]
}
],
"getter": false,
"stringifier": false,
"exposed": "Window Worker",
"mdnUrl": "https://developer.mozilla.org/docs/Web/API/Response/json_static"
},
"clone": {
"name": "clone",
"signature": [
{
"type": "Response",
"nullable": false,
"param": []
}
],
"getter": false,
"static": false,
"stringifier": false,
"exposed": "Window Worker",
"mdnUrl": "https://developer.mozilla.org/docs/Web/API/Response/clone"
}
}
}
},
// ImportMeta is not a true DOM interface, but we are forced to declare it as one in order to emit method definitions.
// We cannot define methods as dictionary properties with function types,
// as this would cause conflicts with ImportMeta method overrides in places like @types/node.
Expand Down Expand Up @@ -604,6 +825,19 @@
"overrideIndexSignatures": [
"[index: number]: Window"
],
"properties": {
"property": {
"Response": {
"name": "Response",
"type": "ResponseConstructor",
"nullable": false,
"readonly": true,
"exposed": "Window",
"secureContext": false,
"mdnUrl": "https://developer.mozilla.org/docs/Web/API/Response/Response"
}
}
},
"events": {
"event": [
{
Expand Down
1 change: 1 addition & 0 deletions inputfiles/removedTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@
},
"interfaces": {
"interface": {
"Response": null,
"Clipboard": {
"methods": {
"method": {
Expand Down
Loading