-
Couldn't load subscription status.
- Fork 453
Refactor mixin handling in KDL parser #2082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 5 commits
91a5892
b69cdd7
368a4dd
8520d04
5b611b8
39ac3c4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| interface-mixin AbstractWorker { | ||
| event error type=ErrorEvent | ||
| } | ||
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,5 +1,5 @@ | ||||||
| import { parse } from "kdljs"; | ||||||
|
||||||
| import { parse } from "kdljs"; | |
| import { parse, type Node } from "kdljs"; |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| export function handleMixin(node: any, mixins: Record<string, any>) { | |
| function handleMixin(node: Node, mixins: Record<string, any>) { |
(Something I missed last time)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this specific case, I'd prefer to put all the event things to a single file as
events.kdl, so that I can see which events are not covered by automation and can ultimately remove this file.In this PR just the filename can change, no addition is needed.
(Because all event data technically exists, we don't have a way to track that to assign automatically right now)