microsoft · github-actions · Aug 2, 2025 · Aug 2, 2025 · Aug 2, 2025 · Aug 2, 2025
diff --git a/inputfiles/overridingTypes.jsonc b/inputfiles/overridingTypes.jsonc
@@ -19,9 +19,6 @@
                     }
                 }
             },
-            "ChildNode": {
-                "extends": "Node"
-            },
             "ParentNode": {
                 "extends": "Node"
             },

diff --git a/inputfiles/patches/childnode.kdl b/inputfiles/patches/childnode.kdl
@@ -0,0 +1 @@
+interface-mixin ChildNode extends="Node"
diff --git a/src/build/patches.ts b/src/build/patches.ts
@@ -92,11 +92,15 @@ function handleMixin(node: Node): DeepPartial<Interface> {
     }
   }
 
-  return {
+  const result: any = {
     name,
     events: { event },
     properties: { property },
-  } as DeepPartial<Interface>;
+  };
-  const result: any = {
-    name,
-    events: { event },
-    properties: { property },
-  } as DeepPartial<Interface>;
-  };
+  const result = {
+name,
+events: { event },
+properties: { property },
+  } as DeepPartial<Interface>;
-  const result: any = {
-    name,
-    events: { event },
-    properties: { property },
-  } as DeepPartial<Interface>;
-  };
+  const result = {
+name,
+events: { event },
+properties: { property },
+  } as DeepPartial<Interface>;
+  if (node.properties.extends) {
+    result.extends = node.properties.extends;
+  }
+  return result as DeepPartial<Interface>;
 }
 
 /**
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		interface-mixin ChildNode extends="Node"
Copy link Contributor saschanaz Aug 2, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. (skip quote) Copy link Contributor saschanaz Aug 2, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Also I don't think it's worth having a separate file for a single line change, but then I'm not sure what would be the right name. Maybe misc.kdl is fine and we can put random simple changes here. Copy link Contributor Author Bashamega Aug 2, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. I think extensions is a good name, because there are a bunch of things that we extend Copy link Contributor saschanaz Aug 2, 2025 • edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. And please cover ParentNode too, and some comment like: `// ChildNode and ParentNode are actually defined as mixins, but because of their names they have historically been used as a sub-interface of Node.` ... with some line wrapping. Copy link Contributor saschanaz Aug 2, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. I think extensions is a good name, because there are a bunch of things that we extend Actually I change my mind here, covering ChildNode/ParentNode with some context is worth a separate file Bashamega reacted with thumbs up emoji Copy link Contributor Author Bashamega Aug 2, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Done Copy link Contributor saschanaz Aug 2, 2025 • edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Now child-parent-node.kdl or such? With that LGTM. Bashamega reacted with rocket emoji Copy link Contributor Author Bashamega Aug 2, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others. Learn more. Done @saschanaz