Convert all enums to KDL format in addedTypes #2099
Conversation
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
inputfiles/patches/rtc.kdl
Outdated
| @@ -0,0 +1,3 @@ | |||
| enum RTCStatsIceCandidatePairState { | |||
| inprogress | |||
There was a problem hiding this comment.
Let's remove this while we are at it, as of now only Gecko has it and thus this should go.
inputfiles/patches/font.kdl
Outdated
| @@ -0,0 +1,8 @@ | |||
| enum FontDisplay { | |||
| @@ -0,0 +1,28 @@ | |||
| enum GlobalCompositeOperation { | |||
inputfiles/patches/positioning.kdl
Outdated
| @@ -0,0 +1,6 @@ | |||
| enum InsertPosition { | |||
| // This is a subset of the permissions defined in the spec: | ||
| // https://w3c.github.io/powerful-features-registry/#registry-table-of-powerful-features | ||
| // Please add a feature only when it's supported by multiple engines. | ||
| // Full support: https://developer.mozilla.org/en-US/docs/Web/API/Permissions_API#browser_compatibility |
There was a problem hiding this comment.
Please keep other comments too from jsonc.
There was a problem hiding this comment.
Uhm no, the same link is just repeating, we should reflect the original comments.
There was a problem hiding this comment.
Sorry @saschanaz
I have fixed it.
I only read the first and last parts and it was the same for me. I didn't see the difference 😄
It should be working now
inputfiles/patches/permissions.kdl
Outdated
| enum PermissionName { | ||
| // This is a subset of the permissions defined in the spec: | ||
| // https://w3c.github.io/powerful-features-registry/#registry-table-of-powerful-features | ||
| // Please add a feature only when it's supported by multiple engines. |
There was a problem hiding this comment.
Can you either move this comment above enum or add a newline between this and full support comment?
| // This is a subset of the permissions defined in the spec: | ||
| // https://w3c.github.io/powerful-features-registry/#registry-table-of-powerful-features | ||
| // Please add a feature only when it's supported by multiple engines. | ||
| // Full support: https://developer.mozilla.org/en-US/docs/Web/API/Permissions_API#browser_compatibility |
There was a problem hiding this comment.
Uhm no, the same link is just repeating, we should reflect the original comments.
|
LGTM, thanks! |
|
There was an issue merging, maybe try again saschanaz. Details |
|
LGTM |
|
Merging because @saschanaz is a code-owner of all the changes - thanks! |
related #2053