Skip to content
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions inputfiles/addedTypes.jsonc
Original file line number Diff line number Diff line change
@@ -1,28 +1,4 @@
{
"mixins": {
"mixin": {
"DocumentOrShadowRoot": {
// Manually moved from Document
// See https://github.com/w3c/csswg-drafts/issues/5886 and https://github.com/w3c/csswg-drafts/issues/556
"methods": {
"method": {
"elementFromPoint": {
"name": "elementFromPoint",
"overrideSignatures": [
"elementFromPoint(x: number, y: number): Element | null"
]
},
"elementsFromPoint": {
"name": "elementsFromPoint",
"overrideSignatures": [
"elementsFromPoint(x: number, y: number): Element[]"
]
}
}
}
}
}
},
"callbackInterfaces": {
"interface": {}
},
Expand Down
12 changes: 12 additions & 0 deletions inputfiles/patches/cssom-view.kd
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
// Manually moved from Document
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.kdl, not .kd 😛

Also maybe 2-space indent to be consistent with the rest of the code 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed the name

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but not the indent 👀

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot, I have updated them

// See https://github.com/w3c/csswg-drafts/issues/5886 and https://github.com/w3c/csswg-drafts/issues/556
interface-mixin DocumentOrShadowRoot {
method elementFromPoint returns=Element nullable=#true {
param x type=long
param y type=long
}
method elementsFromPoint returns="Element" array {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to follow the syntax of

export interface Typed {
type: string | Typed[];
subtype?: Typed | Typed[];
nullable?: boolean;
overrideType?: string;
additionalTypes?: string[];
allowShared?: boolean;
}

But that doesn't seem possible as a property. Perhaps we should allow (but not force) type as a member for complex cases like this.

method elementsFromPoint {
  type sequence {
     type Element
  }
  param x type=long
  param y type=long
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

param x type=long
param y type=long
}
}
35 changes: 34 additions & 1 deletion src/build/patches.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { parse, type Node } from "kdljs";
import type { Enum, Event, Property, Interface, WebIdl } from "./types";
import type { Enum, Event, Property, Interface, WebIdl, Method } from "./types";
import { readdir, readFile } from "fs/promises";
import { merge } from "./helpers.js";

Expand Down Expand Up @@ -76,6 +76,7 @@ function handleMixin(node: Node): DeepPartial<Interface> {

const event: Event[] = [];
const property: Record<string, Partial<Property>> = {};
const method: Record<string, Partial<Method>> = {};

for (const child of node.children) {
switch (child.name) {
Expand All @@ -87,6 +88,11 @@ function handleMixin(node: Node): DeepPartial<Interface> {
property[propName] = handleProperty(child);
break;
}
case "method": {
const methodName = child.values[0] as string;
method[methodName] = handleMethod(child);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Fine for now but eventually this will need to change to support overloads)

break;
}
default:
throw new Error(`Unknown node name: ${child.name}`);
}
Expand All @@ -96,6 +102,7 @@ function handleMixin(node: Node): DeepPartial<Interface> {
name,
events: { event },
properties: { property },
methods: { method },
} as DeepPartial<Interface>;
if (node.properties.extends) {
result.extends = node.properties.extends as string;
Expand Down Expand Up @@ -125,6 +132,32 @@ function handleProperty(child: Node): Partial<Property> {
};
}

/**
* Handles a child node of type "method" and adds it to the method object.
* @param child The child node to handle.
*/
function handleMethod(child: Node): Partial<Method> {
const name = child.values[0] as string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many as string, would be nice to have something like

function string(arg: unknown): string {
  if (typeof arg !== "string") {
    throw new Error(`Expected a string but found ${typeof arg}`);
  }
  return arg;
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

const isArray = child.values[1] as boolean | undefined;
const returnType = child.properties.returns as string;
const nullable = child.properties.nullable as boolean;

const params = child.children.map((c) => ({
name: c.values[0] as string,
type: c.properties.type as string,
}));

const signature: Method["signature"] = [
{
type: isArray ? "sequence" : returnType,
param: params,
nullable,
...(isArray ? { subtype: { type: returnType } } : {}),
},
];
return { name, signature };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This is fine for now but eventually we'll hit a problem when dealing with overloads)

}

/**
* Collect all file URLs in a directory.
*/
Expand Down