-
Notifications
You must be signed in to change notification settings - Fork 446
Feature: Add method handling to mixin processing in KDL #2100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Bashamega
wants to merge
16
commits into
microsoft:main
Choose a base branch
from
Bashamega:kdl/method
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a62a343
Feature: Add method handling to mixin processing in KDL
Bashamega e3f0a20
-
Bashamega d7e96fb
-
Bashamega a88fbed
-
Bashamega 2fcb5b9
Update inputfiles/patches/cssom-view.kd
Bashamega e6da694
Update inputfiles/patches/cssom-view.kd
Bashamega 37825cf
Refactor method signatures in cssom-view.kd to use long type for para…
Bashamega c095db7
Update and rename cssom-view.kd to cssom-view.kdl
Bashamega 9682083
-
Bashamega 6aa05dd
Merge Branches
Bashamega 8f7ca28
Merge branch 'main' into kdl/method
Bashamega 0741374
-
Bashamega 7338aab
Merge branch 'main' into kdl/method
Bashamega 333fb26
chore: split function
Bashamega ea16eb1
filter on param
Bashamega fcd4188
-
Bashamega File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
// Manually moved from Document | ||
// See https://github.com/w3c/csswg-drafts/issues/5886 and https://github.com/w3c/csswg-drafts/issues/556 | ||
interface-mixin DocumentOrShadowRoot { | ||
method elementFromPoint returns="Element | null" { | ||
Bashamega marked this conversation as resolved.
Show resolved
Hide resolved
|
||
param x type=number | ||
param y type=number | ||
} | ||
method elementsFromPoint returns="Element[]" { | ||
Bashamega marked this conversation as resolved.
Show resolved
Hide resolved
|
||
param x type=number | ||
param y type=number | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.kdl, not .kd 😛
Also maybe 2-space indent to be consistent with the rest of the code 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have fixed the name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but not the indent 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot, I have updated them