Remove Nonce #2111
Open
Remove Nonce #2111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
Bashamega
commented
Aug 7, 2025
| @@ -16385,7 +16385,7 @@ interface HTMLOrSVGElement { | |||
| /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/dataset) */ | |||
| readonly dataset: DOMStringMap; | |||
| /** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/nonce) */ | |||
| nonce?: string; | |||
| nonce?: string | undefined; | |||
There was a problem hiding this comment.
This is how the emitter handles optional properties, and I don't see an issue with this
|
The original PR introduced it is #626 Which links to microsoft/TypeScript#28452 At this point everyone supports (This is why additional comments with context would be helpful for each patching) |
|
Thank you for your review @saschanaz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.