Skip to content

Support legacy namespaces for enums #2144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 18, 2025
Merged

Support legacy namespaces for enums #2144

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ee46766
Support legacy namespace
Bashamega Sep 8, 2025
b37b0ac
Merge branch 'microsoft:main' into legacy-enums
Bashamega Sep 8, 2025
48ac7ec
Merge branch 'microsoft:main' into legacy-enums
Bashamega Sep 17, 2025
690ad9f
Rename legacies.kdl to webassembly.kdl
Bashamega Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions inputfiles/overridingTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,12 +347,6 @@
},
"enums": {
"enum": {
"ImportExportKind": {
"legacyNamespace": "WebAssembly"
},
"TableKind": {
"legacyNamespace": "WebAssembly"
},
"ImageOrientation": {
"value": [
// The spec removed this but it's still in browsers and WebKit doesn't support the new one.
Expand Down
2 changes: 2 additions & 0 deletions inputfiles/patches/legacies.kdl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
enum ImportExportKind legacyNamespace=WebAssembly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webassembly.kdl

enum TableKind legacyNamespace=WebAssembly
10 changes: 9 additions & 1 deletion src/build/patches.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,15 @@ function handleEnum(node: Node): Enum {
values.push(child.name);
}

return { name, value: values };
return {
name,
value: values,
...optionalMember(
"legacyNamespace",
"string",
node.properties.legacyNamespace,
),
};
}

/**
Expand Down