Skip to content

Migrate ImageOrientation to KDL #2150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 20, 2025
Merged

Migrate ImageOrientation to KDL #2150

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3986c6d
Migrate ImageOrientation to KDL
Bashamega Sep 20, 2025
47dc443
-
Bashamega Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions inputfiles/overridingTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,21 +342,6 @@
}
}
},
"callbackInterfaces": {
"interface": {}
},
"enums": {
"enum": {
"ImageOrientation": {
"value": [
// The spec removed this but it's still in browsers and WebKit doesn't support the new one.
// Keep it until it's safer to fully migrate.
// See https://github.com/microsoft/TypeScript-DOM-lib-generator/issues/1507#issuecomment-1454792451
"none"
]
}
}
},
"interfaces": {
"interface": {
"CryptoKey": {
Expand Down
7 changes: 7 additions & 0 deletions inputfiles/patches/dom.kdl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,10 @@ enum InsertPosition {
afterbegin
afterend
}

enum ImageOrientation {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not dom but html, so html.kdl

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

// The spec removed this but it's still in browsers and WebKit doesn't support the new one.
// Keep it until it's safer to fully migrate.
// See https://github.com/microsoft/TypeScript-DOM-lib-generator/issues/1507#issuecomment-1454792451
none
}