-
Notifications
You must be signed in to change notification settings - Fork 452
Support methods without names in interfaces #2169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6b4dfa3
Support callable
Bashamega 819aa60
-
Bashamega 06cc4db
anonymousMethods
Bashamega 6d68997
-
Bashamega bed7ab1
Merge branch 'microsoft:main' into handle-callable
Bashamega 6ed028b
Update patches.ts
Bashamega daadce6
Update dom.kdl
Bashamega 104628c
Delete inputfiles/patches/forced-declare.kdl
Bashamega File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
// Keeping EventListener and EventListenerObject isn't the most elegant way to handle the event listeners, but we need to keep the EventListener as an extendable interface for libraries like angular. | ||
interface EventListener noInterfaceObject=#true { | ||
method "" returns=void { | ||
param evt type=Event | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -244,17 +244,18 @@ function handleMethod(child: Node): Partial<Method> { | |
} | ||
} | ||
|
||
if (!typeNode) { | ||
throw new Error(`Method "${name}" is missing a return type`); | ||
} | ||
|
||
const signature: Method["signature"] = [ | ||
{ | ||
param: params, | ||
...handleTyped(typeNode), | ||
...(typeNode | ||
? handleTyped(typeNode) | ||
: { type: string(child.properties?.returns) }), | ||
}, | ||
]; | ||
return { name, signature }; | ||
return { | ||
...optionalMember("name", "string", name), | ||
|
||
signature, | ||
}; | ||
} | ||
|
||
/** | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Erm actually this is dom, let's put this in dom.kdl