-
Notifications
You must be signed in to change notification settings - Fork 460
Migrate HTMLInputElement #2338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate HTMLInputElement #2338
Changes from 1 commit
c1f04d8
15d830b
4ad16bd
2d928d3
cad1aa8
841cd82
8b49df9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,6 +47,22 @@ interface HTMLImageElement { | |
| property loading overrideType=#""eager" | "lazy""# | ||
| } | ||
|
|
||
| interface HTMLInputElement { | ||
| property labels { | ||
| type NodeListOf { | ||
| type HTMLLabelElement | ||
| } | ||
| } | ||
| property autocomplete type=AutoFill | ||
| property valueAsDate type=Date | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure this should be allowed, Date is not an IDL type. But maybe not worth disallowing it... Let's see. |
||
| property selectionDirection type=Directions | ||
| method setSelectionRange signatureIndex=0 { | ||
| param start nullable=#true | ||
| param end nullable=#true | ||
| param direction type=Directions | ||
| } | ||
| } | ||
|
|
||
| dictionary StructuredSerializeOptions { | ||
| member transfer { | ||
| type { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -320,6 +320,7 @@ function handleParam(node: Node) { | |
| name, | ||
| ...optionalMember("type", "string", node.properties?.type), | ||
| ...optionalMember("overrideType", "string", node.properties?.overrideType), | ||
| ...optionalMember("nullable", "boolean", node.properties?.nullable), | ||
|
||
| additionalTypes, | ||
| }; | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a plan to remove that again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, let's keep it in the JSON until we migrate because we still don't have support for type defs in KDL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.