Skip to content

Commit e6bfce1

Browse files
committed
Add additional TODO about insertion positions
1 parent 13e60bc commit e6bfce1

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/services/refactors/extractSymbol.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1110,6 +1110,7 @@ namespace ts.refactor.extractSymbol {
11101110
}
11111111

11121112
// TODO (acasey): need to dig into nested statements
1113+
// TODO (acasey): don't insert before pinned comments, directives, or triple-slash references
11131114
function getNodeToInsertConstantBefore(maxPos: number, scope: Scope): Node {
11141115
const children = getStatementsOrClassElements(scope);
11151116
Debug.assert(children.length > 0); // There must be at least one child, since we extracted from one.
@@ -1126,6 +1127,7 @@ namespace ts.refactor.extractSymbol {
11261127
}
11271128
}
11281129

1130+
Debug.assert(prevChild !== undefined);
11291131
return prevChild;
11301132
}
11311133

0 commit comments

Comments
 (0)