-
Notifications
You must be signed in to change notification settings - Fork 13k
align ClassStaticBlockDeclaration with IIFE in CFA #44969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
fa66faf
align ClassStaticBlockDeclaration with IIFE in CFA
Zzzen 2af5e8e
isIIFELike => isImmediatelyInvoked
Zzzen 038d7c4
fix unexpected used-before-assignment errors
Zzzen 7b074c5
Merge branch 'microsoft:main' into cfa-in-class-static-block
Zzzen 311ed52
fix unexpected used-before-assignment errors in class static block
Zzzen ecb3adb
update baseline
Zzzen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -657,19 +657,23 @@ namespace ts { | |
const saveExceptionTarget = currentExceptionTarget; | ||
const saveActiveLabelList = activeLabelList; | ||
const saveHasExplicitReturn = hasExplicitReturn; | ||
const isIIFE = containerFlags & ContainerFlags.IsFunctionExpression && !hasSyntacticModifier(node, ModifierFlags.Async) && | ||
!(node as FunctionLikeDeclaration).asteriskToken && !!getImmediatelyInvokedFunctionExpression(node); | ||
const isIIFELike = | ||
(containerFlags & ContainerFlags.IsFunctionExpression && | ||
!hasSyntacticModifier(node, ModifierFlags.Async) && | ||
!(node as FunctionLikeDeclaration).asteriskToken && | ||
!!getImmediatelyInvokedFunctionExpression(node)) || | ||
node.kind === SyntaxKind.ClassStaticBlockDeclaration; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am not sure how to format these lines, so here is how prettier handles it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would have done it slightly differently, but prettier's format is fine. |
||
// A non-async, non-generator IIFE is considered part of the containing control flow. Return statements behave | ||
// similarly to break statements that exit to a label just past the statement body. | ||
if (!isIIFE) { | ||
if (!isIIFELike) { | ||
currentFlow = initFlowNode({ flags: FlowFlags.Start }); | ||
if (containerFlags & (ContainerFlags.IsFunctionExpression | ContainerFlags.IsObjectLiteralOrClassExpressionMethod)) { | ||
currentFlow.node = node as FunctionExpression | ArrowFunction | MethodDeclaration; | ||
} | ||
} | ||
// We create a return control flow graph for IIFEs and constructors. For constructors | ||
// we use the return control flow graph in strict property initialization checks. | ||
currentReturnTarget = isIIFE || node.kind === SyntaxKind.Constructor || node.kind === SyntaxKind.ClassStaticBlockDeclaration || (isInJSFile(node) && (node.kind === SyntaxKind.FunctionDeclaration || node.kind === SyntaxKind.FunctionExpression)) ? createBranchLabel() : undefined; | ||
currentReturnTarget = isIIFELike || node.kind === SyntaxKind.Constructor || (isInJSFile(node) && (node.kind === SyntaxKind.FunctionDeclaration || node.kind === SyntaxKind.FunctionExpression)) ? createBranchLabel() : undefined; | ||
currentExceptionTarget = undefined; | ||
currentBreakTarget = undefined; | ||
currentContinueTarget = undefined; | ||
|
@@ -695,7 +699,7 @@ namespace ts { | |
(node as FunctionLikeDeclaration | ClassStaticBlockDeclaration).returnFlowNode = currentFlow; | ||
} | ||
} | ||
if (!isIIFE) { | ||
if (!isIIFELike) { | ||
currentFlow = saveCurrentFlow; | ||
} | ||
currentBreakTarget = saveBreakTarget; | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
//// [classStaticBlock28.ts] | ||
let foo: number; | ||
|
||
class C { | ||
static { | ||
foo = 1 | ||
} | ||
} | ||
|
||
console.log(foo) | ||
|
||
//// [classStaticBlock28.js] | ||
"use strict"; | ||
var foo; | ||
var C = /** @class */ (function () { | ||
function C() { | ||
} | ||
return C; | ||
}()); | ||
(function () { | ||
foo = 1; | ||
})(); | ||
console.log(foo); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
=== tests/cases/conformance/classes/classStaticBlock/classStaticBlock28.ts === | ||
let foo: number; | ||
>foo : Symbol(foo, Decl(classStaticBlock28.ts, 0, 3)) | ||
|
||
class C { | ||
>C : Symbol(C, Decl(classStaticBlock28.ts, 0, 16)) | ||
|
||
static { | ||
foo = 1 | ||
>foo : Symbol(foo, Decl(classStaticBlock28.ts, 0, 3)) | ||
} | ||
} | ||
|
||
console.log(foo) | ||
>console.log : Symbol(Console.log, Decl(lib.dom.d.ts, --, --)) | ||
>console : Symbol(console, Decl(lib.dom.d.ts, --, --)) | ||
>log : Symbol(Console.log, Decl(lib.dom.d.ts, --, --)) | ||
>foo : Symbol(foo, Decl(classStaticBlock28.ts, 0, 3)) | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
=== tests/cases/conformance/classes/classStaticBlock/classStaticBlock28.ts === | ||
let foo: number; | ||
>foo : number | ||
|
||
class C { | ||
>C : C | ||
|
||
static { | ||
foo = 1 | ||
>foo = 1 : 1 | ||
>foo : number | ||
>1 : 1 | ||
} | ||
} | ||
|
||
console.log(foo) | ||
>console.log(foo) : void | ||
>console.log : (...data: any[]) => void | ||
>console : Console | ||
>log : (...data: any[]) => void | ||
>foo : number | ||
|
11 changes: 11 additions & 0 deletions
11
tests/cases/conformance/classes/classStaticBlock/classStaticBlock28.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
// @strict: true | ||
|
||
let foo: number; | ||
|
||
class C { | ||
static { | ||
foo = 1 | ||
} | ||
} | ||
|
||
console.log(foo) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(or
isImmediate
for even more old-school flavor)