-
Notifications
You must be signed in to change notification settings - Fork 13k
Make go to definition go to the constraint's properties for object literals in argument positions #62361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Andarist
wants to merge
1
commit into
microsoft:main
Choose a base branch
from
Andarist:gotodef-obj-literal-constraint-def
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+206
−13
Open
Make go to definition go to the constraint's properties for object literals in argument positions #62361
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
154 changes: 154 additions & 0 deletions
154
tests/baselines/reference/goToDefinitionObjectLiteralProperties2.baseline.jsonc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,154 @@ | ||
| // === goToDefinition === | ||
| // === /tests/cases/fourslash/goToDefinitionObjectLiteralProperties2.ts === | ||
| // type C = { | ||
| // <|[|foo|]: string;|> | ||
| // bar: number; | ||
| // }; | ||
| // | ||
| // declare function fn<T extends C>(arg: T): T; | ||
| // | ||
| // fn({ | ||
| // foo/*GOTO DEF*/: "", | ||
| // bar: true, | ||
| // }); | ||
| // | ||
| // --- (line: 13) skipped --- | ||
|
|
||
| // === Details === | ||
| [ | ||
| { | ||
| "kind": "property", | ||
| "name": "foo", | ||
| "containerName": "__type", | ||
| "isLocal": false, | ||
| "isAmbient": false, | ||
| "unverified": false | ||
| } | ||
| ] | ||
|
|
||
|
|
||
|
|
||
| // === goToDefinition === | ||
| // === /tests/cases/fourslash/goToDefinitionObjectLiteralProperties2.ts === | ||
| // type C = { | ||
| // foo: string; | ||
| // <|[|bar|]: number;|> | ||
| // }; | ||
| // | ||
| // declare function fn<T extends C>(arg: T): T; | ||
| // | ||
| // fn({ | ||
| // foo: "", | ||
| // bar/*GOTO DEF*/: true, | ||
| // }); | ||
| // | ||
| // const result = fn({ | ||
| // --- (line: 14) skipped --- | ||
|
|
||
| // === Details === | ||
| [ | ||
| { | ||
| "kind": "property", | ||
| "name": "bar", | ||
| "containerName": "__type", | ||
| "isLocal": false, | ||
| "isAmbient": false, | ||
| "unverified": false | ||
| } | ||
| ] | ||
|
|
||
|
|
||
|
|
||
| // === goToDefinition === | ||
| // === /tests/cases/fourslash/goToDefinitionObjectLiteralProperties2.ts === | ||
| // type C = { | ||
| // <|[|foo|]: string;|> | ||
| // bar: number; | ||
| // }; | ||
| // | ||
| // --- (line: 6) skipped --- | ||
|
|
||
| // --- (line: 10) skipped --- | ||
| // }); | ||
| // | ||
| // const result = fn({ | ||
| // foo/*GOTO DEF*/: "", | ||
| // bar: 1, | ||
| // }); | ||
| // | ||
| // // this one shouldn't go to the constraint type | ||
| // result.foo; | ||
|
|
||
| // === Details === | ||
| [ | ||
| { | ||
| "kind": "property", | ||
| "name": "foo", | ||
| "containerName": "__type", | ||
| "isLocal": false, | ||
| "isAmbient": false, | ||
| "unverified": false | ||
| } | ||
| ] | ||
|
|
||
|
|
||
|
|
||
| // === goToDefinition === | ||
| // === /tests/cases/fourslash/goToDefinitionObjectLiteralProperties2.ts === | ||
| // type C = { | ||
| // foo: string; | ||
| // <|[|bar|]: number;|> | ||
| // }; | ||
| // | ||
| // declare function fn<T extends C>(arg: T): T; | ||
| // --- (line: 7) skipped --- | ||
|
|
||
| // --- (line: 11) skipped --- | ||
| // | ||
| // const result = fn({ | ||
| // foo: "", | ||
| // bar/*GOTO DEF*/: 1, | ||
| // }); | ||
| // | ||
| // // this one shouldn't go to the constraint type | ||
| // result.foo; | ||
|
|
||
| // === Details === | ||
| [ | ||
| { | ||
| "kind": "property", | ||
| "name": "bar", | ||
| "containerName": "__type", | ||
| "isLocal": false, | ||
| "isAmbient": false, | ||
| "unverified": false | ||
| } | ||
| ] | ||
|
|
||
|
|
||
|
|
||
| // === goToDefinition === | ||
| // === /tests/cases/fourslash/goToDefinitionObjectLiteralProperties2.ts === | ||
| // --- (line: 10) skipped --- | ||
| // }); | ||
| // | ||
| // const result = fn({ | ||
| // <|[|foo|]: ""|>, | ||
| // bar: 1, | ||
| // }); | ||
| // | ||
| // // this one shouldn't go to the constraint type | ||
| // result.foo/*GOTO DEF*/; | ||
|
|
||
| // === Details === | ||
| [ | ||
| { | ||
| "kind": "property", | ||
| "name": "foo", | ||
| "containerName": "__object", | ||
| "isLocal": false, | ||
| "isAmbient": false, | ||
| "unverified": false, | ||
| "failedAliasResolution": false | ||
| } | ||
| ] |
23 changes: 23 additions & 0 deletions
23
tests/cases/fourslash/goToDefinitionObjectLiteralProperties2.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| /// <reference path='fourslash.ts'/> | ||
|
|
||
| //// type C = { | ||
| //// foo: string; | ||
| //// bar: number; | ||
| //// }; | ||
| //// | ||
| //// declare function fn<T extends C>(arg: T): T; | ||
| //// | ||
| //// fn({ | ||
| //// foo/*1*/: "", | ||
| //// bar/*2*/: true, | ||
| //// }); | ||
| //// | ||
| //// const result = fn({ | ||
| //// foo/*3*/: "", | ||
| //// bar/*4*/: 1, | ||
| //// }); | ||
| //// | ||
| //// // this one shouldn't go to the constraint type | ||
| //// result.foo/*5*/; | ||
|
|
||
| verify.baselineGoToDefinition("1", "2", "3", "4", "5"); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As shown by this PR, this mechanism is handy for other things than just completions - so I decided to rename it.