Port microsoft/typescript-go#1764 #62510

ahejlsberg · 2025-09-29T20:09:33Z

Copilot

Pull Request Overview

This PR ports a change from the typescript-go repository that replaces direct object flag checking with a more appropriate type guard function call.

Replaces manual ObjectFlags.FreshLiteral flag checking with isObjectLiteralType() function call

ahejlsberg · 2025-09-29T20:10:49Z

@typescript-bot test it

typescript-bot · 2025-09-29T20:10:55Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-09-29T20:34:51Z

Hey @ahejlsberg, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-09-29T20:38:25Z

@ahejlsberg Here are the results of running the user tests with tsc comparing main and refs/pull/62510/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Git clone failed"

Otherwise...

Everything looks good!

typescript-bot · 2025-09-29T20:59:36Z

@ahejlsberg
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,370	_62,370	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,386	_50,386	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,380k (± 0.74%)}	_{193,984k (± 0.97%)}	_~	_192,758k	_196,464k	_{p=0.423 n=6}
_{Parse Time}	_{1.29s (± 0.90%)}	_{1.30s (± 0.84%)}	_~	_1.28s	_1.31s	_{p=0.246 n=6}
_{Bind Time}	_{0.72s (± 0.57%)}	_0.72s	_~	_~	_~	_{p=0.405 n=6}
_{Check Time}	_{9.76s (± 0.40%)}	_{9.74s (± 0.42%)}	_~	_9.70s	_9.80s	_{p=0.687 n=6}
_{Emit Time}	_{2.75s (± 0.42%)}	_{2.74s (± 0.99%)}	_~	_2.70s	_2.78s	_{p=0.286 n=6}
_{Total Time}	_{14.52s (± 0.28%)}	_{14.50s (± 0.49%)}	_~	_14.40s	_14.58s	_{p=0.687 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,914	_948,914	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,884	_410,884	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,245,598k (± 0.00%)}	_{1,245,621k (± 0.00%)}	_~	_1,245,567k	_1,245,699k	_{p=0.873 n=6}
_{Parse Time}	_{6.51s (± 0.63%)}	_{6.47s (± 0.55%)}	_~	_6.43s	_6.52s	_{p=0.326 n=6}
_{Bind Time}	_{1.87s (± 0.79%)}	_{1.87s (± 0.40%)}	_~	_1.86s	_1.88s	_{p=1.000 n=6}
_{Check Time}	_{32.22s (± 0.48%)}	_{32.12s (± 0.35%)}	_~	_31.92s	_32.26s	_{p=0.173 n=6}
_{Emit Time}	_{14.77s (± 0.24%)}	_{14.79s (± 0.38%)}	_~	_14.75s	_14.90s	_{p=0.462 n=6}
_{Total Time}	_{55.36s (± 0.33%)}	_{55.25s (± 0.31%)}	_~	_55.00s	_55.52s	_{p=0.173 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,544,632	_2,544,632	_~	_~	_~	_{p=1.000 n=6}
_Types	_903,208	_903,208	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,829,952k (± 0.00%)}	_{2,829,953k (± 0.01%)}	_~	_2,829,703k	_2,830,097k	_{p=0.936 n=6}
_{Parse Time}	_{8.73s (± 0.28%)}	_{8.74s (± 0.30%)}	_~	_8.71s	_8.78s	_{p=0.625 n=6}
_{Bind Time}	_{2.22s (± 0.44%)}	_{2.22s (± 0.23%)}	_~	_2.22s	_2.23s	_{p=0.348 n=6}
_{Check Time}	_{86.16s (± 0.50%)}	_{86.08s (± 0.72%)}	_~	_85.57s	_87.28s	_{p=0.298 n=6}
_{Emit Time}	_{0.63s (±124.75%)}	_{0.61s (±123.09%)}	_~	_0.30s	_2.15s	_{p=0.383 n=6}
_{Total Time}	_{97.74s (± 1.03%)}	_{97.65s (± 0.80%)}	_~	_96.87s	_98.74s	_{p=0.689 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,237,063	_1,237,063	_~	_~	_~	_{p=1.000 n=6}
_Types	_259,743	_259,743	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,485,695k (± 7.55%)}	_{2,424,762k (± 6.11%)}	_~	_2,363,211k	_2,727,529k	_{p=0.575 n=6}
_{Parse Time}	_{5.17s (± 0.67%)}	_{5.13s (± 0.73%)}	_~	_5.10s	_5.20s	_{p=0.065 n=6}
_{Bind Time}	_{1.77s (± 0.66%)}	_{1.77s (± 0.87%)}	_~	_1.76s	_1.80s	_{p=1.000 n=6}
_{Check Time}	_{34.94s (± 0.62%)}	_{34.94s (± 0.42%)}	_~	_34.69s	_35.08s	_{p=0.810 n=6}
_{Emit Time}	_{3.00s (± 1.18%)}	_{3.05s (± 4.24%)}	_~	_2.95s	_3.31s	_{p=0.810 n=6}
_{Total Time}	_{44.87s (± 0.51%)}	_{44.91s (± 0.39%)}	_~	_44.62s	_45.16s	_{p=0.810 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,237,063	_1,237,063	_~	_~	_~	_{p=1.000 n=6}
_Types	_259,743	_259,743	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,158,279k (± 0.02%)}	_{3,158,133k (± 0.02%)}	_~	_3,157,495k	_3,158,824k	_{p=0.471 n=6}
_{Parse Time}	_{6.86s (± 0.97%)}	_{6.86s (± 0.61%)}	_~	_6.80s	_6.91s	_{p=0.630 n=6}
_{Bind Time}	_{2.16s (± 0.81%)}	_{2.15s (± 0.42%)}	_~	_2.14s	_2.16s	_{p=0.089 n=6}
_{Check Time}	_{42.53s (± 0.19%)}	_{42.51s (± 0.46%)}	_~	_42.27s	_42.77s	_{p=0.936 n=6}
_{Emit Time}	_{3.45s (± 2.75%)}	_{3.51s (± 2.82%)}	_~	_3.36s	_3.66s	_{p=0.173 n=6}
_{Total Time}	_{55.01s (± 0.29%)}	_{55.06s (± 0.29%)}	_~	_54.92s	_55.36s	_{p=0.689 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,411	_262,411	_~	_~	_~	_{p=1.000 n=6}
_Types	_103,924	_103,924	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{440,479k (± 0.01%)}	_{440,476k (± 0.01%)}	_~	_440,403k	_440,535k	_{p=0.810 n=6}
_{Parse Time}	_{3.51s (± 0.98%)}	_{3.51s (± 0.73%)}	_~	_3.47s	_3.54s	_{p=0.570 n=6}
_{Bind Time}	_{1.33s (± 1.03%)}	_{1.33s (± 0.82%)}	_~	_1.32s	_1.35s	_{p=0.365 n=6}
_{Check Time}	_{19.03s (± 0.08%)}	_{19.02s (± 0.34%)}	_~	_18.95s	_19.10s	_{p=1.000 n=6}
_{Emit Time}	_{1.54s (± 0.96%)}	_{1.53s (± 0.87%)}	_~	_1.51s	_1.55s	_{p=0.190 n=6}
_{Total Time}	_{25.41s (± 0.17%)}	_{25.40s (± 0.30%)}	_~	_25.30s	_25.51s	_{p=0.810 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₂	₇₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,367	_225,367	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,290	_94,290	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,996k (± 0.04%)}	_{369,960k (± 0.02%)}	_~	_369,891k	_370,048k	_{p=0.936 n=6}
_{Parse Time}	_{2.84s (± 1.79%)}	_{2.83s (± 0.62%)}	_~	_2.82s	_2.86s	_{p=0.257 n=6}
_{Bind Time}	_{1.60s (± 0.92%)}	_{1.59s (± 0.92%)}	_~	_1.57s	_1.61s	_{p=0.289 n=6}
_{Check Time}	_{16.46s (± 0.29%)}	_{16.47s (± 0.25%)}	_~	_16.42s	_16.52s	_{p=0.629 n=6}
_{Emit Time}	_{0.00s (±244.70%)}	_0.00s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{20.91s (± 0.43%)}	_{20.90s (± 0.22%)}	_~	_20.85s	_20.95s	_{p=0.935 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,896,281	_3,896,281	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,225,516	_1,225,516	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,708,541k (± 0.00%)}	_{3,708,575k (± 0.00%)}	_~	_3,708,371k	_3,708,711k	_{p=0.470 n=6}
_{Parse Time}	_{15.30s (± 0.63%)}	_{15.24s (± 0.56%)}	_~	_15.11s	_15.32s	_{p=0.422 n=6}
_{Bind Time}	_{5.01s (± 3.08%)}	_{5.03s (± 2.93%)}	_~	_4.91s	_5.28s	_{p=0.575 n=6}
_{Check Time}	_{101.48s (± 1.75%)}	_{102.42s (± 3.08%)}	_~	_100.24s	_108.13s	_{p=0.298 n=6}
_{Emit Time}	_{32.24s (± 9.69%)}	_{33.80s (±19.70%)}	_~	_30.68s	_47.38s	_{p=1.000 n=6}
_{Total Time}	_{154.04s (± 2.89%)}	_{156.49s (± 5.16%)}	_~	_151.13s	_171.79s	_{p=0.575 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₃₈	₃₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_361,947	_361,947	_~	_~	_~	_{p=1.000 n=6}
_Types	_158,950	_158,950	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{516,720k (± 0.01%)}	_{516,696k (± 0.02%)}	_~	_516,568k	_516,802k	_{p=0.810 n=6}
_{Parse Time}	_{4.45s (± 1.10%)}	_{4.45s (± 0.37%)}	_~	_4.43s	_4.47s	_{p=0.936 n=6}
_{Bind Time}	_{1.92s (± 1.50%)}	_{1.91s (± 2.39%)}	_~	_1.86s	_1.98s	_{p=0.520 n=6}
_{Check Time}	_{21.65s (± 0.24%)}	_{21.68s (± 0.34%)}	_~	_21.60s	_21.80s	_{p=0.630 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.01s (± 0.24%)}	_{28.03s (± 0.37%)}	_~	_27.94s	_28.23s	_{p=0.872 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_672,790	_672,790	_~	_~	_~	_{p=1.000 n=6}
_Types	_201,962	_201,962	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{574,837k (± 0.03%)}	_{574,911k (± 0.02%)}	_~	_574,733k	_575,054k	_{p=0.378 n=6}
_{Parse Time}	_{4.18s (± 0.92%)}	_{4.17s (± 0.58%)}	_~	_4.15s	_4.22s	_{p=0.747 n=6}
_{Bind Time}	_{1.33s (± 0.67%)}	_{1.33s (± 0.88%)}	_~	_1.31s	_1.34s	_{p=0.933 n=6}
_{Check Time}	_{20.71s (± 1.76%)}	_{20.50s (± 1.98%)}	_~	_20.14s	_21.09s	_{p=0.575 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{26.22s (± 1.46%)}	_{26.00s (± 1.54%)}	_~	_25.67s	_26.61s	_{p=0.575 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-09-29T21:30:12Z

@ahejlsberg Here are the results of running the top 400 repos with tsc comparing main and refs/pull/62510/merge:

Everything looks good!

Revert back to isObjectLiteralType check

b8448c3

Copilot AI review requested due to automatic review settings September 29, 2025 20:09

github-project-automation bot added this to PR Backlog Sep 29, 2025

github-project-automation bot moved this to Not started in PR Backlog Sep 29, 2025

typescript-bot assigned ahejlsberg Sep 29, 2025

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Sep 29, 2025

Copilot AI reviewed Sep 29, 2025

View reviewed changes

ahejlsberg requested a review from jakebailey September 29, 2025 20:09

jakebailey approved these changes Sep 29, 2025

View reviewed changes

github-project-automation bot moved this from Not started to Needs merge in PR Backlog Sep 29, 2025

ahejlsberg merged commit e350126 into main Sep 29, 2025
33 checks passed

ahejlsberg deleted the port-tsgo-1764 branch September 29, 2025 21:48

github-project-automation bot moved this from Needs merge to Done in PR Backlog Sep 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Port microsoft/typescript-go#1764 #62510

Port microsoft/typescript-go#1764 #62510

ahejlsberg commented Sep 29, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

ahejlsberg commented Sep 29, 2025

Uh oh!

typescript-bot commented Sep 29, 2025 •

edited

Loading

Uh oh!

typescript-bot commented Sep 29, 2025

Uh oh!

typescript-bot commented Sep 29, 2025

Uh oh!

typescript-bot commented Sep 29, 2025

tsc

Uh oh!

typescript-bot commented Sep 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Port microsoft/typescript-go#1764 #62510

Port microsoft/typescript-go#1764 #62510

Conversation

ahejlsberg commented Sep 29, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

ahejlsberg commented Sep 29, 2025

Uh oh!

typescript-bot commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Sep 29, 2025

Uh oh!

typescript-bot commented Sep 29, 2025

Uh oh!

typescript-bot commented Sep 29, 2025

tsc

Uh oh!

typescript-bot commented Sep 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

typescript-bot commented Sep 29, 2025 •

edited

Loading