Skip to content

prime95 fix #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ await this.Logger.LogMessageAsync($"{this.TypeName}.ExecuteWorkload", telemetryC
if (process.Start())
{
await this.WaitAsync(explicitTimeout, cancellationToken);
process.SafeKill();
process.Kill(entireProcessTree: true);

if (!cancellationToken.IsCancellationRequested)
{
Expand All @@ -302,15 +302,14 @@ await this.Logger.LogMessageAsync($"{this.TypeName}.ExecuteWorkload", telemetryC
{
results = await this.fileSystem.File.ReadAllTextAsync(this.ResultsFilePath);
}

if (string.IsNullOrWhiteSpace(results))
{
throw new WorkloadResultsException(
$"Prime95 results file not found at path '{this.ResultsFilePath}'.",
ErrorReason.WorkloadResultsNotFound);
}

// The exit code on SafeKill is -1 which is not a part of the default success codes.
process.ThrowIfWorkloadFailed(this.successExitCodes);
this.CaptureMetrics(process, results, telemetryContext, cancellationToken);
}
Expand Down
4 changes: 1 addition & 3 deletions website/docs/workloads/prime95/prime95.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ The following list describes the measurements captured by the workload running a

* Number of Tests passed.
* Number of Tests failed.
* Time-to-Compute the Tests (in seconds).

## Workload Metrics
The following metrics are examples of those captured by the Virtual Client when running the Prime95 workload.
Expand All @@ -54,5 +53,4 @@ for which the system was stressed with torture test. A higher the test time with
| Metric Name | Example Value (min) | Example Value (max) | Example Value (avg) | Unit |
|--------------|---------------------|---------------------|---------------------|------|
| failTestCount | 0.0 | 0.0 | 0.0 | |
| passTestCount | 32.0 | 192.0 | 115.45833333333333 | |
| testTime | 3600.0031989 | 3601.679443 | 3600.23347608125 | seconds |
| passTestCount | 32.0 | 192.0 | 115.45833333333333 | |
Loading