Users/nmalkapuram/postresqlhammerdbsupporton arm #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on x64 as hammerdb doesn't itself support arm
yangpanMS
reviewed
Aug 4, 2025
| bool isX64 = this.CpuArchitecture == System.Runtime.InteropServices.Architecture.X64; | ||
| bool isArm64 = this.CpuArchitecture == System.Runtime.InteropServices.Architecture.Arm64; | ||
|
|
||
| bool isArchitectureSupported = isX64 || (isServerExecutorInServerRole && isArm64); |
There was a problem hiding this comment.
Please document which distro is supported on which arch in the document.
yangpanMS
reviewed
Aug 4, 2025
| "MinimumExecutionInterval": "00:01:00", | ||
| "Metadata": { | ||
| "RecommendedMinimumExecutionTime": "04:00:00", | ||
| "SupportedPlatforms": "linux-x64", |
There was a problem hiding this comment.
Profile says ARM64 but here it says linux-x64, first, is it possible that we run on both x64 and arm64. Second could we merge the profile?
There was a problem hiding this comment.
This was redundant profile, I have added the working profile to blob storage. That works for asymmetric client server architecture. (arm46 server and x64 client). Let me know if I need to add this here.
There was a problem hiding this comment.
For discoverability please add here and use arch agnostic profile if available.
yangpanMS
requested changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.