Fix dmesg warning from enable crash dump collection #14035
Merged
+18
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR eliminates a dmesg warning by removing an unnecessary call to WSLAEnableCrashDumpCollection() after chroot. The function writes to /proc/sys/kernel/core_pattern, but after chroot, /proc is not mounted in the new root, causing the write to fail and generate error logs. The crash dump collection is already configured earlier in WSLAEntryPoint before any chroot occurs, so the post-chroot call was redundant.
Key Changes:
- Removed redundant
WSLAEnableCrashDumpCollection()call after chroot operation inHandleMessageImpl - Moved the
WSLAEnableCrashDumpCollection()call to execute after logging initialization inWSLAEntryPoint
src/linux/init/WSLAInit.cpp
Outdated
| } | ||
|
|
||
| // | ||
| // Enable dump colleciton when processes crash. |
There was a problem hiding this comment.
Spelling error: "colleciton" should be "collection".
Suggested change
| // Enable dump colleciton when processes crash. | |
| // Enable dump collection when processes crash. |
OneBlue
approved these changes
Jan 7, 2026
Collaborator
OneBlue
left a comment
OneBlue
left a comment
There was a problem hiding this comment.
LGTM. Let's just fix the typo that copilot pointed out and we're good to merge this
Member
|
Looks like the test isn't passing. |
benhillis
approved these changes
Jan 12, 2026
OneBlue
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change eliminates an unnecessary write to
/proc/sys/kernel/core_patternin WSLAInit after the chroot operation. Crash dump collection is already configured at theWSLAEntryPointbefore chroot, so the post-chroot write adds no value.After chroot, /proc is not mounted in the new root, causing the write to fail. The failed write previously logged an error, creating noise without functional impact.
Additionally, this PR moves the WSLAEnableCrashDumpCollection call to later in WSLAEntryPoint so that logging is fully initialized when crash dump collection is enabled.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed