Merge master -> feature/wsl-for-apps#14064
Closed
benhillis wants to merge 9 commits intofeature/wsl-for-appsfrom
Closed
Merge master -> feature/wsl-for-apps#14064benhillis wants to merge 9 commits intofeature/wsl-for-appsfrom
benhillis wants to merge 9 commits intofeature/wsl-for-appsfrom
Conversation
Updating .appx and .wsl offerings.
Update DistributionInfo.json to add "eLxr" section to "ModenDistributions". This commit adds eLxr to the Microsoft WSL's official distribution manifest, allowing users to pull and install it in an automated way (`wsl --install eLxr`).
* Update StartDhcpClient to use dhcpcd which is the Azure Linux 3 equivalent * Update Microsoft.WSLg to version 1.0.72 which moves to Azure Linux 3
Co-authored-by: WSL localization <noreply@microsoft.com>
Keep command-line install/unregister eLxr operations consistent
Co-authored-by: WSL localization <noreply@microsoft.com>
* diagnostics: combine wprp files in a single one with profiles --------- Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com>
* cleanup: refactor svccommio class * add logging if setting code page fails * pr feedback * remove unneeded if * remove unneeded if * pr feedbacK' --------- Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request merges changes from the master branch into the feature/wsl-for-apps branch. The changes encompass networking test additions, a significant refactoring of console I/O handling to use RAII patterns, a migration from dhclient to dhcpcd in the Linux init system, package version updates, localization improvements, and a consolidation of diagnostic tracing profiles.
Changes:
- Adds new bridged networking smoke tests and IPv4/IPv6 connectivity tests
- Refactors console I/O management using RAII wrappers for automatic resource cleanup
- Migrates DHCP client from dhclient to dhcpcd with updated configuration
- Updates WSLg package version and distribution metadata
- Improves Turkish and German localizations
- Consolidates diagnostic .wprp files into a single multi-profile configuration
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/windows/NetworkTests.cpp | Adds three new bridged networking tests with internet connectivity checks |
| src/windows/common/svccommio.hpp | Refactors to RAII-based console handle management with new ConsoleInput/ConsoleOutput classes |
| src/windows/common/svccommio.cpp | Implements RAII wrappers and simplifies console configuration logic |
| src/linux/init/main.cpp | Migrates from dhclient to dhcpcd with updated command-line arguments |
| packages.config | Updates Microsoft.WSLg from 1.0.71 to 1.0.72 |
| localization/strings/tr-TR/Resources.resw | Multiple Turkish localization improvements |
| localization/strings/de-DE/Resources.resw | Multiple German localization improvements |
| doc/docs/debugging.md | Documents new consolidated wprp profiles |
| distributions/DistributionInfo.json | Updates openSUSE Tumbleweed versions and adds eLxr distribution |
| diagnostics/wsl.wprp | Consolidates multiple .wprp files into one with multiple profiles |
| diagnostics/wsl_storage.wprp | Removed (consolidated into wsl.wprp) |
| diagnostics/wsl_networking.wprp | Removed (consolidated into wsl.wprp) |
| diagnostics/wsl_hvsocket.wprp | Removed (consolidated into wsl.wprp) |
| diagnostics/collect-wsl-logs.ps1 | Updated to use consolidated wprp file with profile selection |
| diagnostics/collect-networking-logs.ps1 | Updated to use WSL-Networking profile from consolidated wprp |
| CONTRIBUTING.md | Documents new log profile options |
| .github/copilot-instructions.md | Updates internal documentation with new profile information |
| </data> | ||
| <data name="MessageReadOnlyDistro" xml:space="preserve"> | ||
| <value>Dağıtım diski bağlanırken bir hata oluştu, geri dönüş olarak salt okunur olarak bağlandı. | ||
| <value>ağıtım diski bağlanırken bir hata oluştu, yedek plan olarak salt okunur şekilde bağlandı. |
There was a problem hiding this comment.
Missing first letter 'D' in the word 'Dağıtım' (Distribution). The word appears as 'ağıtım' instead of 'Dağıtım'.
Suggested change
| <value>ağıtım diski bağlanırken bir hata oluştu, yedek plan olarak salt okunur şekilde bağlandı. | |
| <value>Dağıtım diski bağlanırken bir hata oluştu, yedek plan olarak salt okunur şekilde bağlandı. |
| </data> | ||
| <data name="MessageVmModeNotSupported" xml:space="preserve"> | ||
| <value>WSL 2 wird von der Legacyverteilung nicht unterstützt.</value> | ||
| <value>WSL 2 wird von der Legacy Distribution nicht unterstütztt.</value> |
There was a problem hiding this comment.
Double 't' typo in 'unterstütztt'. Should be 'unterstützt' with a single 't' at the end.
Suggested change
| <value>WSL 2 wird von der Legacy Distribution nicht unterstütztt.</value> | |
| <value>WSL 2 wird von der Legacy Distribution nicht unterstützt.</value> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.