merge master -> feature/wsl-for-apps#14085
Closed
benhillis wants to merge 4 commits intouser/benhill/merge_console_fixfrom
Closed
merge master -> feature/wsl-for-apps#14085benhillis wants to merge 4 commits intouser/benhill/merge_console_fixfrom
benhillis wants to merge 4 commits intouser/benhill/merge_console_fixfrom
Conversation
Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com>
* cleanup: fix UserConfig.cmake.sample in master branch * remove incorrect wsldevicehost.dll handling, wix file always uses the version from the bin folder --------- Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com>
…ove operator (#14083) The ConsoleInput and ConsoleOutput classes used = default move operations, which caused the moved-from temporary's destructor to restore the original console mode (re-enabling ENABLE_PROCESSED_INPUT) after the object was moved into the std::optional. The fix uses emplace() to construct objects directly in-place, avoiding moves entirely. Move operations are now deleted to prevent future misuse. Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.