Skip to content

Fix app title bar gap beneath the caption buttons #2051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fix app title bar gap beneath the caption buttons #2051

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e4162ee
Fix titlebar gap under caption buttons
AndrewKeepCoding Sep 17, 2025
b148634
Revert "Fix titlebar gap under caption buttons"
AndrewKeepCoding Sep 19, 2025
0f16190
Adjust NavigationView margin based on window state
AndrewKeepCoding Sep 19, 2025
5f5a9fa
Merge branch 'main' into app-titlebar-gap-fix
AndrewKeepCoding Sep 29, 2025
0267903
Handle nullable WindowPresenter
AndrewKeepCoding Oct 6, 2025
32f2313
Merge branch 'main' into app-titlebar-gap-fix
AndrewKeepCoding Oct 6, 2025
e31538f
Merge branch 'main' into app-titlebar-gap-fix
AndrewKeepCoding Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions WinUIGallery/MainWindow.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
<MicaBackdrop />
</Window.SystemBackdrop>
<Grid x:Name="RootGrid" Loaded="RootGrid_Loaded">
<Grid.Resources>
<x:Double x:Key="TitleBarExpandedHeight">46</x:Double>
Copy link

@Saharsh979 Saharsh979 Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was 46 chosen as the value for TitleBarExpandedHeight?
Is this value derived via observation? If yes, then a hardcoded workaround might break under different conditions (e.g., DPI scaling, theme changes, or different Windows versions, resolution settings)

Copy link
Contributor Author

@AndrewKeepCoding AndrewKeepCoding Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Saharsh979! Thanks for pointing that out. I should’ve mentioned that I tested the fix under different DPI, resolutions, and while switching between them on Win 11.
That said, the current title bar already relies on some hardcoded width/height values, so I followed the same approach here. I couldn’t find a more flexible way to address the gap, but I’m definitely open to better alternatives if you have suggestions.

</Grid.Resources>
<Grid.RowDefinitions>
<RowDefinition Height="Auto" />
<RowDefinition Height="*" />
Expand Down