Correct Package Family Name Construction for Main and Singleton Packages #5729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
manodasanW
reviewed
Aug 26, 2025
manodasanW
reviewed
Aug 26, 2025
Scottj1s
reviewed
Aug 26, 2025
Scottj1s
reviewed
Aug 26, 2025
Scottj1s
reviewed
Aug 26, 2025
DrusTheAxe
reviewed
Aug 27, 2025
DrusTheAxe
requested changes
Aug 27, 2025
address PR comments
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
manodasanW
approved these changes
Sep 2, 2025
guimafelipe
reviewed
Sep 3, 2025
DrusTheAxe
reviewed
Sep 4, 2025
dev/Deployment/DeploymentManager.cpp
Outdated
| } | ||
|
|
||
| unsigned int numberBeforeUnderscore; | ||
| if (swscanf_s(versionTag.c_str(), L"%*[^0-9]%u", &numberBeforeUnderscore) == 1) |
There was a problem hiding this comment.
What's the [^0-9] do here? Wondering how this differs from "%u"
dev/Deployment/DeploymentManager.cpp
Outdated
| else | ||
| { | ||
| formattedVersionTag = L""; | ||
| } | ||
| } | ||
| else | ||
| { | ||
| // Other version types not supported. | ||
| FAIL_FAST_HR(HRESULT_FROM_WIN32(ERROR_UNSUPPORTED_TYPE)); |
There was a problem hiding this comment.
FAIL_FAST will crash the process. Seems pretty harsh considering this is an inproc API running in some app's process space, and giving them no chance to note the issue or recover.
Why not THROW_HR_MSG(HRESULT_FROM_WIN32(ERROR_UNSUPPORTED_TYPE), "%d", static_cast<int>(package.versionType));?
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change corrects the construction of the packageFamilyName for the main and singleton packages in DeploymentManager.cpp. Previously, the package family names were being built incorrectly, which caused the DeploymentManager to incorrectly determine that these packages were not installed. As a result, the deployment status was reported as PackageInstallRequired instead of Ok.
Details
• Fixed the logic that formats the version tag and constructs the packageFamilyName for main and singleton packages.
• With the corrected names, DeploymentManager now accurately detects installed packages and returns the correct deployment status.
Testing
The fix was validated in the debugger: after the change, the deployment status is Ok when the packages are present.
A microsoft employee must use /azp run to validate using the pipelines below.
WARNING:
Comments made by azure-pipelines bot maybe inaccurate.
Please see pipeline link to verify that the build is being ran.
For status checks on the main branch, please use TransportPackage-Foundation-PR
(https://microsoft.visualstudio.com/ProjectReunion/_build?definitionId=81063&_a=summary)
and run the build against your PR branch with the default parameters.