-
Notifications
You must be signed in to change notification settings - Fork 1k
Python: multiple bug fixes #3150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+35
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ChatAgent.run Fixes microsoft#3118
… in Azure AI Agents Fixes microsoft#3147
Member
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request fixes three bugs in the Python agent framework:
- Fixes #3147 by allowing AzureAIClient to provide a custom error message when model_deployment_name is missing
- Fixes #3118 by ensuring kwargs are properly forwarded in the Agent.run() method, consistent with run_stream()
- Fixes #3041 by using the prepare_function_call_results() function for better serialization of function results in span attributes
Key Changes
- Extracted model presence validation into a separate overridable method
_check_model_presence() - Changed function result serialization in observability spans to use
prepare_function_call_results()instead ofjson.dumps() - Added
**kwargsforwarding to_prepare_thread_and_messages()call in Agent.run()
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| python/packages/core/agent_framework/openai/_responses_client.py | Refactored model_id validation into separate _check_model_presence() method to enable subclass customization |
| python/packages/core/agent_framework/_tools.py | Updated function result serialization to use prepare_function_call_results() for better handling of complex types |
| python/packages/core/agent_framework/_agents.py | Added **kwargs forwarding in run() method to match run_stream() behavior |
| python/packages/azure-ai/agent_framework_azure_ai/_client.py | Overrode _check_model_presence() to provide Azure-specific error message referencing model_deployment_name |
python/packages/core/agent_framework/openai/_responses_client.py
Outdated
Show resolved
Hide resolved
python/packages/core/agent_framework/openai/_responses_client.py
Outdated
Show resolved
Hide resolved
TaoChenOSU
approved these changes
Jan 9, 2026
moonbox3
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes #3147 by overriding error message for AzureAIClient.
Fixes #3118 by adding kwargs in the same way for run as we do in run_stream
Fixes #3041 by completely serializing the function result in the span attribute
Description
Contribution Checklist