-
Notifications
You must be signed in to change notification settings - Fork 1k
.NET: [BREAKING] Migrate ChatMessageStores to be AIContextProviders and rename to ChatHistoryProviders #3221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
westey-m
wants to merge
11
commits into
microsoft:main
Choose a base branch
from
westey-m:chatmessagestore-migrate-and-rename
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
5199a9f
Migrate ChatMessageStores to be AIContextProviders and rename to Chat…
westey-m 71930f0
Merge branch 'main' into chatmessagestore-migrate-and-rename
westey-m 4c832a2
Fix some xml docs
westey-m 05bff48
Merge branch 'chatmessagestore-migrate-and-rename' of https://github.…
westey-m e23f44e
Rename state object names
westey-m 5b74602
Update unit tests after changing serialization
westey-m 5b5123b
Merge branch 'main' into chatmessagestore-migrate-and-rename
westey-m 92ca4bb
Pass ChatHistoryMessages to AIContextProvider.InvokedAsync
westey-m 9fc2b73
Merge branch 'chatmessagestore-migrate-and-rename' of https://github.…
westey-m e798487
Merge branch 'main' into chatmessagestore-migrate-and-rename
westey-m d493371
Merge branch 'main' into chatmessagestore-migrate-and-rename
westey-m File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
dotnet/src/Microsoft.Agents.AI.Abstractions/AIContextProviderExtensions.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| // Copyright (c) Microsoft. All rights reserved. | ||
|
|
||
| using System; | ||
|
|
||
| namespace Microsoft.Agents.AI; | ||
|
|
||
| /// <summary> | ||
| /// Contains extension methods for the <see cref="AIContextProvider"/> class. | ||
| /// </summary> | ||
| public static class AIContextProviderExtensions | ||
| { | ||
| /// <summary> | ||
| /// Adds message filtering to an existing <see cref="AIContextProvider"/>, so that data passed to to and from it | ||
| /// can be filtered, updated or replaced. | ||
| /// </summary> | ||
| /// <param name="innerAIContextProvider">The underlying AI context provider to be wrapped. Cannot be null.</param> | ||
| /// <param name="invokingContextFilter">An optional filter function to apply to the AI context before it is returned. If null, no filter is applied at this | ||
| /// stage.</param> | ||
| /// <param name="invokedContextFilter">An optional filter function to apply to the invocation context before it is consumed. If null, no | ||
| /// filter is applied at this stage.</param> | ||
| /// <returns>The <see cref="AIContextProvider"/> with filtering applied.</returns> | ||
| public static AIContextProvider WithMessageFilters( | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this effectively creating a pipeline of providers as decorators? |
||
| this AIContextProvider innerAIContextProvider, | ||
| Func<AIContext, AIContext>? invokingContextFilter = null, | ||
| Func<AIContextProvider.InvokedContext, AIContextProvider.InvokedContext>? invokedContextFilter = null) | ||
| { | ||
| return new MessageFilteringAIContextProvider( | ||
| innerAIContextProvider, | ||
| invokingContextFilter, | ||
| invokedContextFilter); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Decorates the provided <see cref="AIContextProvider"/> so that it does not receive messages produced by any <see cref="AIContextProvider"/>. | ||
| /// </summary> | ||
| /// <param name="innerAIContextProvider">The underlying AI context provider to add the filter to. Cannot be null.</param> | ||
| /// <returns>A new <see cref="AIContextProvider"/> instance that filters out <see cref="AIContextProvider"/> messages.</returns> | ||
| public static AIContextProvider WithAIContextProviderMessageRemoval(this AIContextProvider innerAIContextProvider) | ||
| { | ||
| return new MessageFilteringAIContextProvider( | ||
| innerAIContextProvider, | ||
| invokedContextFilter: (ctx) => | ||
| { | ||
| ctx.AIContextProviderMessages = null; | ||
| return ctx; | ||
| }); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the difference between this and AIContextProviderMessages? If the idea is that a chat message store is now a context provider, then isn't such a context provider's messages the history?