Add initial skeleton of package, including tooling setup and CI #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moonbox3
reviewed
May 7, 2025
moonbox3
approved these changes
May 9, 2025
4 tasks
ReubenBond
pushed a commit
to ReubenBond/agent-framework
that referenced
this pull request
Oct 28, 2025
…osoft#4) * Add initial skeleton of package, including tooling setup and CI * update workflow * update uv * add bandit
Jeyaramjj
pushed a commit
to Jeyaramjj/agent-framework
that referenced
this pull request
Nov 5, 2025
This is the first PR in a series to port Google service connectors from Semantic Kernel to Agent Framework. Changes: - Created agent_framework_google package structure - Added GoogleAISettings class for Gemini API - Added VertexAISettings class for Vertex AI - Comprehensive test coverage (17 test cases) - Documentation with usage examples and roadmap - Updated .gitignore for internal dev docs Following azure-ai connector pattern as reference (with py.typed). Future PRs will add: - PR microsoft#2: GoogleAIChatClient implementation - PR microsoft#3: GoogleAI integration tests & samples - PR microsoft#4: VertexAIChatClient implementation - PR microsoft#5: VertexAI integration tests & samples - PR microsoft#6: Advanced features & polish Dependencies verified against Semantic Kernel: - google-generativeai>=0.8,<1 (SK uses ~=0.8) - google-cloud-aiplatform>=1.60,<2 (SK uses ~=1.114.0)
eavanvalkenburg
pushed a commit
that referenced
this pull request
Nov 7, 2025
* feat(python): Add Google AI/Vertex AI package scaffolding (1/6) This is the first PR in a series to port Google service connectors from Semantic Kernel to Agent Framework. Changes: - Created agent_framework_google package structure - Added GoogleAISettings class for Gemini API - Added VertexAISettings class for Vertex AI - Comprehensive test coverage (17 test cases) - Documentation with usage examples and roadmap - Updated .gitignore for internal dev docs Following azure-ai connector pattern as reference (with py.typed). Future PRs will add: - PR #2: GoogleAIChatClient implementation - PR #3: GoogleAI integration tests & samples - PR #4: VertexAIChatClient implementation - PR #5: VertexAI integration tests & samples - PR #6: Advanced features & polish Dependencies verified against Semantic Kernel: - google-generativeai>=0.8,<1 (SK uses ~=0.8) - google-cloud-aiplatform>=1.60,<2 (SK uses ~=1.114.0) * refactor: align with Anthropic pattern - use location, chat_model_id, and version fields for Google settings * Address PR #1938 review comments: migrate to google-genai SDK, add Python 3.14, simplify to Google AI only - Migrate from google-generativeai to google-genai SDK (>=0.2,<1) - Add Python 3.14 classifier support - Simplify to Google AI only (remove VertexAI settings and tests) - Remove google-cloud-aiplatform dependency - Update README to reflect Google AI focus and google-genai SDK - Add comprehensive GAP_ANALYSIS.md with 4-phase implementation plan - Add PR1938_CHECKLIST.md tracking review feedback and next steps - Verify implementation against official Google migration guide - All tests passing (5 tests, 100% coverage) Addresses feedback from @eavanvalkenburg: 1. Added Python 3.14 support 2. Switched to google-genai (GA release, Google-recommended) 3. Removed VertexAI to simplify first iteration * fix: Address pre-commit hooks failures - Export GoogleAISettings in __init__.py for public API - Update README.md example to use SecretStr for type safety - Comment out future code example to avoid pyright validation errors - Auto-format code with ruff Addresses CI feedback from PR reviewer. --------- Co-authored-by: Jeyaram Jeyaraj <[email protected]>
Jeyaramjj
added a commit
to Jeyaramjj/agent-framework
that referenced
this pull request
Dec 12, 2025
* feat(python): Add Google AI/Vertex AI package scaffolding (1/6) This is the first PR in a series to port Google service connectors from Semantic Kernel to Agent Framework. Changes: - Created agent_framework_google package structure - Added GoogleAISettings class for Gemini API - Added VertexAISettings class for Vertex AI - Comprehensive test coverage (17 test cases) - Documentation with usage examples and roadmap - Updated .gitignore for internal dev docs Following azure-ai connector pattern as reference (with py.typed). Future PRs will add: - PR microsoft#2: GoogleAIChatClient implementation - PR microsoft#3: GoogleAI integration tests & samples - PR microsoft#4: VertexAIChatClient implementation - PR microsoft#5: VertexAI integration tests & samples - PR microsoft#6: Advanced features & polish Dependencies verified against Semantic Kernel: - google-generativeai>=0.8,<1 (SK uses ~=0.8) - google-cloud-aiplatform>=1.60,<2 (SK uses ~=1.114.0) * refactor: align with Anthropic pattern - use location, chat_model_id, and version fields for Google settings * Address PR microsoft#1938 review comments: migrate to google-genai SDK, add Python 3.14, simplify to Google AI only - Migrate from google-generativeai to google-genai SDK (>=0.2,<1) - Add Python 3.14 classifier support - Simplify to Google AI only (remove VertexAI settings and tests) - Remove google-cloud-aiplatform dependency - Update README to reflect Google AI focus and google-genai SDK - Add comprehensive GAP_ANALYSIS.md with 4-phase implementation plan - Add PR1938_CHECKLIST.md tracking review feedback and next steps - Verify implementation against official Google migration guide - All tests passing (5 tests, 100% coverage) Addresses feedback from @eavanvalkenburg: 1. Added Python 3.14 support 2. Switched to google-genai (GA release, Google-recommended) 3. Removed VertexAI to simplify first iteration * fix: Address pre-commit hooks failures - Export GoogleAISettings in __init__.py for public API - Update README.md example to use SecretStr for type safety - Comment out future code example to avoid pyright validation errors - Auto-format code with ruff Addresses CI feedback from PR reviewer. --------- Co-authored-by: Jeyaram Jeyaraj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.