Skip to content

Fix pyright errors from weave ≥0.52.27 interface changes #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Fix pyright errors from weave ≥0.52.27 interface changes #497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d79bde6
Initial plan
Copilot Feb 28, 2026
a151d96
Initial plan for fixing pyright errors
Copilot Feb 28, 2026
c75bf98
Fix pyright errors: update weave interface for OTelExportReq rename a…
Copilot Feb 28, 2026
f487e48
Revert weave version bump; use TYPE_CHECKING guard for backward compat
Copilot Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,3 +218,5 @@ agentlightning/dashboard/**/*.svg

# Docker data
docker/data/
.cache_xdg/
.cache_uv/
21 changes: 18 additions & 3 deletions agentlightning/instrumentation/weave.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import threading
import warnings
from datetime import datetime, timezone
from typing import Any, Callable, Dict, Iterator, List
from typing import TYPE_CHECKING, Any, Callable, Dict, Iterator, List

import weave.trace.weave_init
from pydantic import validate_call
Expand All @@ -17,6 +17,12 @@

logger = logging.getLogger(__name__)

# Backward compat: OtelExportReq/Res was renamed to OTelExportReq/Res in weave 0.52.27
if not TYPE_CHECKING:
if not hasattr(tsi, "OTelExportReq"):
tsi.OTelExportReq = tsi.OtelExportReq
tsi.OTelExportRes = tsi.OtelExportRes

__all__ = [
"instrument_weave",
"uninstrument_weave",
Expand Down Expand Up @@ -303,8 +309,8 @@ def evaluation_status(self, req: tsi.EvaluationStatusReq) -> tsi.EvaluationStatu

# --- OTEL API ---

def otel_export(self, req: tsi.OtelExportReq) -> tsi.OtelExportRes:
return tsi.OtelExportRes()
def otel_export(self, req: tsi.OTelExportReq) -> tsi.OTelExportRes:
return tsi.OTelExportRes()

# ==========================================
# Object Interface (V2 APIs)
Expand Down Expand Up @@ -364,6 +370,9 @@ def evaluation_list(self, req: tsi.EvaluationListReq) -> Iterator[tsi.Evaluation
def evaluation_delete(self, req: tsi.EvaluationDeleteReq) -> tsi.EvaluationDeleteRes:
return tsi.EvaluationDeleteRes(num_deleted=0)

def eval_results_query(self, req: tsi.EvalResultsQueryReq) -> tsi.EvalResultsQueryRes:
return tsi.EvalResultsQueryRes(rows=[], total_rows=0)

# --- Models ---
def model_create(self, req: tsi.ModelCreateReq) -> tsi.ModelCreateRes:
return tsi.ModelCreateRes(
Expand Down Expand Up @@ -435,6 +444,12 @@ def annotation_queues_query_stream(self, *args: Any, **kwargs: Any) -> Any:
def annotation_queue_read(self, *args: Any, **kwargs: Any) -> Any:
raise NotImplementedError()

def annotation_queue_delete(self, *args: Any, **kwargs: Any) -> Any:
raise NotImplementedError()

def annotation_queue_update(self, *args: Any, **kwargs: Any) -> Any:
raise NotImplementedError()

def annotation_queue_add_calls(self, *args: Any, **kwargs: Any) -> Any:
raise NotImplementedError()

Expand Down