Clarify pragma warning comment for outputBitmap ownership transfer#552
Merged
weiyuanyue merged 2 commits intomilly/idispfrom Jan 8, 2026
Merged
Clarify pragma warning comment for outputBitmap ownership transfer#552weiyuanyue merged 2 commits intomilly/idispfrom
weiyuanyue merged 2 commits intomilly/idispfrom
Conversation
6 tasks
The comment now correctly explains that outputBitmap's ownership is transferred to become the new _inputBitmap value, not to the old _inputBitmap. Co-authored-by: weiyuanyue <176483933+weiyuanyue@users.noreply.github.com>
weiyuanyue
approved these changes
Jan 8, 2026
Copilot
AI
changed the title
[WIP] Update IDisposable Analyzer warnings based on feedback
Clarify pragma warning comment for outputBitmap ownership transfer
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pragma warning disable comment in
MagicEraser.xaml.cswas misleading about ownership transfer semantics.Changes:
outputBitmapbecomes the new_inputBitmap, not that ownership is transferred to the old valueThe corrected comment now accurately reflects the code flow:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.