Skip to content

fix: Address 4 Accessibility Bugs #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haoliuu merged 4 commits into from
Jan 14, 2026
Merged

fix: Address 4 Accessibility Bugs #561

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
56408e9
Fix Name Property and Keyboard Focus
haoliuu Jan 13, 2026
be80881
Maintain the Keyboard focus when the selected file is null
haoliuu Jan 13, 2026
54ecf95
Fix text truncated issue
haoliuu Jan 13, 2026
72fda3e
Merge branch 'main' into haoliu/accessibility-fix
haoliuu Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion AIDevGallery/Controls/ModelPicker/AddHFModelView.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,9 @@
Grid.Row="1"
HorizontalAlignment="Center"
Foreground="{ThemeResource TextFillColorSecondaryBrush}"
Text="Browse and download generative language models from Hugging Face." />
Text="Browse and download generative language models from Hugging Face."
TextAlignment="Center"
TextWrapping="Wrap" />
<Grid
Grid.Row="2"
MaxWidth="560"
Expand Down
2 changes: 1 addition & 1 deletion AIDevGallery/Samples/Open Source Models/Image Models/ESRGAN/SuperResolution.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,10 @@ private async void UploadButton_Click(object sender, RoutedEventArgs e)

// Pick a file
var file = await picker.PickSingleFileAsync();
UploadButton.Focus(FocusState.Programmatic);
if (file != null)
{
// Call function to run inference and classify image
UploadButton.Focus(FocusState.Programmatic);
SendSampleInteractedEvent("FileSelected"); // <exclude-line>
await EnhanceImage(file.Path);
}
Expand Down
2 changes: 2 additions & 0 deletions AIDevGallery/Samples/Open Source Models/Image Models/FFNet/SegmentStreets.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
Visibility="Collapsed" />
<Grid
Margin="8"
Padding="2"
HorizontalAlignment="Right"
VerticalAlignment="Top"
Background="{ThemeResource AcrylicBackgroundFillColorDefaultBrush}"
Expand All @@ -44,6 +45,7 @@
Padding="8"
AutomationProperties.Name="Select image"
Click="UploadButton_Click"
FocusVisualMargin="-3"
ToolTipService.ToolTip="Select image">

<FontIcon FontSize="16" Glyph="&#xEE71;" />
Expand Down
6 changes: 3 additions & 3 deletions AIDevGallery/Samples/Open Source Models/Image Models/FFNet/SegmentStreets.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,9 @@ private async void UploadButton_Click(object sender, RoutedEventArgs e)
picker.ViewMode = PickerViewMode.Thumbnail;

var file = await picker.PickSingleFileAsync();
UploadButton.Focus(FocusState.Programmatic);
if (file != null)
{
UploadButton.Focus(FocusState.Programmatic);
SendSampleInteractedEvent("FileSelected"); // <exclude-line>
await Segment(file.Path);
}
Expand All @@ -148,7 +148,7 @@ private async Task Segment(string filePath)
UploadButton.Visibility = Visibility.Collapsed;

DefaultImage.Source = new BitmapImage(new Uri(filePath));
NarratorHelper.AnnounceImageChanged(DefaultImage, "Image changed: new upload."); // <exclude-line>
NarratorHelper.AnnounceImageChanged(DefaultImage, "Content changed: new upload."); // <exclude-line>

using Bitmap originalImage = new(filePath);
int originalImageWidth = originalImage.Width;
Expand Down Expand Up @@ -271,7 +271,7 @@ private async Task Segment(string filePath)
// Convert the final overlay to BitmapImage for display
BitmapImage outputImage = BitmapFunctions.ConvertBitmapToBitmapImage(processedImage);

NarratorHelper.AnnounceImageChanged(DefaultImage, "Image changed: all regions segmented."); // <exclude-line>
NarratorHelper.AnnounceImageChanged(DefaultImage, "Content changed: all regions segmented."); // <exclude-line>

DispatcherQueue.TryEnqueue(() =>
{
Expand Down
2 changes: 1 addition & 1 deletion AIDevGallery/Samples/Open Source Models/Image Models/Faster RCNN/ObjectDetection.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,9 +130,9 @@ private async void UploadButton_Click(object sender, RoutedEventArgs e)
picker.ViewMode = PickerViewMode.Thumbnail;

var file = await picker.PickSingleFileAsync();
UploadButton.Focus(FocusState.Programmatic);
if (file != null)
{
UploadButton.Focus(FocusState.Programmatic);
SendSampleInteractedEvent("FileSelected"); // <exclude-line>
await DetectObjects(file.Path);
}
Expand Down
2 changes: 2 additions & 0 deletions AIDevGallery/Samples/Open Source Models/Image Models/HRNetPose/PoseDetection.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
Visibility="Collapsed" />
<Grid
Margin="8"
Padding="2"
HorizontalAlignment="Right"
VerticalAlignment="Top"
Background="{ThemeResource AcrylicBackgroundFillColorDefaultBrush}"
Expand All @@ -44,6 +45,7 @@
Padding="8"
AutomationProperties.Name="Select image"
Click="UploadButton_Click"
FocusVisualMargin="-3"
ToolTipService.ToolTip="Select image">

<FontIcon FontSize="16" Glyph="&#xEE71;" />
Expand Down
6 changes: 3 additions & 3 deletions AIDevGallery/Samples/Open Source Models/Image Models/HRNetPose/PoseDetection.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,9 @@ private async void UploadButton_Click(object sender, RoutedEventArgs e)
picker.ViewMode = PickerViewMode.Thumbnail;

var file = await picker.PickSingleFileAsync();
UploadButton.Focus(FocusState.Programmatic);
if (file != null)
{
UploadButton.Focus(FocusState.Programmatic);
SendSampleInteractedEvent("FileSelected"); // <exclude-line>
await DetectPose(file.Path);
}
Expand All @@ -146,7 +146,7 @@ private async Task DetectPose(string filePath)
Loader.Visibility = Visibility.Visible;
UploadButton.Visibility = Visibility.Collapsed;
DefaultImage.Source = new BitmapImage(new Uri(filePath));
NarratorHelper.AnnounceImageChanged(DefaultImage, "Image changed: new upload."); // <exclude-line>
NarratorHelper.AnnounceImageChanged(DefaultImage, "Content changed: new upload."); // <exclude-line>

using Bitmap originalImage = new(filePath);

Expand Down Expand Up @@ -182,7 +182,7 @@ private async Task DetectPose(string filePath)

using Bitmap output = PoseHelper.RenderPredictions(originalImage, predictions, .02f);
BitmapImage outputImage = BitmapFunctions.ConvertBitmapToBitmapImage(output);
NarratorHelper.AnnounceImageChanged(DefaultImage, "Image changed: key points rendered."); // <exclude-line>
NarratorHelper.AnnounceImageChanged(DefaultImage, "Content changed: key points rendered."); // <exclude-line>

DispatcherQueue.TryEnqueue(() =>
{
Expand Down
2 changes: 2 additions & 0 deletions AIDevGallery/Samples/Open Source Models/Image Models/MultiHRNetPose/Multipose.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
Visibility="Collapsed" />
<Grid
Margin="8"
Padding="2"
HorizontalAlignment="Right"
VerticalAlignment="Top"
Background="{ThemeResource AcrylicBackgroundFillColorDefaultBrush}"
Expand All @@ -44,6 +45,7 @@
Padding="8"
AutomationProperties.Name="Select image"
Click="UploadButton_Click"
FocusVisualMargin="-3"
ToolTipService.ToolTip="Select image">

<FontIcon FontSize="16" Glyph="&#xEE71;" />
Expand Down
2 changes: 1 addition & 1 deletion AIDevGallery/Samples/Open Source Models/Image Models/MultiHRNetPose/Multipose.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,10 +152,10 @@ private async void UploadButton_Click(object sender, RoutedEventArgs e)
picker.ViewMode = PickerViewMode.Thumbnail;

var file = await picker.PickSingleFileAsync();
UploadButton.Focus(FocusState.Programmatic);
if (file != null)
{
// Call function to run inference and classify image
UploadButton.Focus(FocusState.Programmatic);
SendSampleInteractedEvent("FileSelected"); // <exclude-line>
await RunPipeline(file.Path);
}
Expand Down
2 changes: 1 addition & 1 deletion AIDevGallery/Samples/Open Source Models/Image Models/YOLOv4/YOLOObjectDetection.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,10 @@ private async void UploadButton_Click(object sender, RoutedEventArgs e)

// Pick a file
var file = await picker.PickSingleFileAsync();
UploadButton.Focus(FocusState.Programmatic);
if (file != null)
{
// Call function to run inference and classify image
UploadButton.Focus(FocusState.Programmatic);
SendSampleInteractedEvent("FileSelected"); // <exclude-line>
await DetectObjects(file.Path);
}
Expand Down
Loading