Fix race condition in CancellationTokenSource disposal#562
Merged
weiyuanyue merged 2 commits intomilly/idispfrom Jan 15, 2026
Merged
Fix race condition in CancellationTokenSource disposal#562weiyuanyue merged 2 commits intomilly/idispfrom
weiyuanyue merged 2 commits intomilly/idispfrom
Conversation
6 tasks
Co-authored-by: weiyuanyue <176483933+weiyuanyue@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix feedback on IDisposable analyzer warnings
Fix race condition in CancellationTokenSource disposal
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CancelCTS()method inSampleContainerhad a race condition where concurrent calls could cause double-disposal ofCancellationTokenSource. The pattern of reading, nulling, and disposing without synchronization allowed multiple threads to read the same non-null reference before any thread nulled it.Changes:
_ctsLockobject to serialize all_sampleLoadingCtsaccessCancelCTS()with lockCancellationTokenSourcecreation/disposal inLoadSampleAsyncwith lockBefore:
After:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.