Fix some references to LifecycleHooks that were actually Event Subscr…

[afscrome]

Description

I noticed a few event subscribers still referred to LifecycleHook in their class / method names. Renamed those it was safe to do. (Tests / internal classes)

Checklist

• Is this feature complete?
  • Yes. Ready to ship.
• Are you including unit tests for the changes and scenario tests if relevant?
  • No
• Did you add public API?
  • No
• Does the change make any security assumptions or guarantees?
  • No
• Does the change require an update in our Aspire docs?
  • No

[github-actions]

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15053

Or

• Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15053"

[Copilot]

Pull request overview

Aligns internal eventing subscriber naming in Aspire.Hosting (and associated tests) by replacing outdated *LifecycleHook* identifiers with *EventingSubscriber* / EventHandlers terminology, matching the current eventing model.

Changes:

• Renamed internal required-command validation subscriber and updated DI registration + test assertions.
• Renamed devcontainer port-forwarding subscriber and updated DI registration + test assertions.
• Renamed dashboard test class to match DashboardEventHandlers.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/Aspire.Hosting.Tests/RequiredCommandAnnotationTests.cs	Updates test names/assertions and doc comment to refer to RequiredCommandValidationEventingSubscriber.
tests/Aspire.Hosting.Tests/DistributedApplicationBuilderTests.cs	Updates default-service assertions to the renamed subscriber types.
tests/Aspire.Hosting.Tests/Dashboard/DashboardEventHandlersTests.cs	Renames the test class from DashboardLifecycleHookTests to DashboardEventHandlersTests.
src/Aspire.Hosting/Lifecycle/RequiredCommandValidationEventingSubscriber.cs	Renames the internal subscriber type to RequiredCommandValidationEventingSubscriber.
src/Aspire.Hosting/DistributedApplicationBuilder.cs	Updates eventing subscriber registrations to the renamed types.
src/Aspire.Hosting/Devcontainers/DevcontainerPortForwardingEventingSubscriber.cs	Renames the devcontainer eventing subscriber type and constructor.

Comments suppressed due to low confidence (1)

tests/Aspire.Hosting.Tests/Dashboard/DashboardEventHandlersTests.cs:25

• This test file now uses DashboardEventHandlersTests, but helper/variable names still use the older "hook" terminology (e.g., CreateHook, hook). Consider renaming those to match DashboardEventHandlers to keep naming consistent within the test suite.

[Copilot]

The XML doc comment now describes subscribing eventing subscribers, but the helper is still named SubscribeHooksAsync. Renaming the method (and its call sites) to something like SubscribeEventingSubscribersAsync would keep terminology consistent and avoid confusion with lifecycle hooks.