[cli] Shorten install script download logging#15405
Merged
DamianEdwards merged 4 commits intomainfrom Mar 20, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15405Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15405" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Bash and PowerShell “get-aspire-cli” installers to avoid printing full download URLs in log/WhatIf output by deriving a compact “download descriptor” from known URL shapes.
Changes:
- Add URL-to-descriptor helpers (
get_download_descriptor/Get-DownloadDescriptor) and use them in download/validation logging. - Update download/validation error messages to reference the descriptor instead of the raw URL.
- Adjust dry-run /
-WhatIfmessaging for CLI archive and VS Code extension downloads to avoid surfacing full URLs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| eng/scripts/get-aspire-cli.sh | Introduces a descriptor helper and replaces URL logging in curl/download/validation paths. |
| eng/scripts/get-aspire-cli.ps1 | Adds a descriptor helper and updates download/logging and ShouldProcess messaging to avoid full URLs. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
DamianEdwards
commented
Mar 19, 2026
DamianEdwards
commented
Mar 19, 2026
DamianEdwards
commented
Mar 19, 2026
DamianEdwards
commented
Mar 19, 2026
DamianEdwards
commented
Mar 19, 2026
DamianEdwards
commented
Mar 19, 2026
DamianEdwards
commented
Mar 19, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
nit: looks good overall. I noticed a small bit of dead code from the new descriptor plumbing: |
radical
approved these changes
Mar 19, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
@radical removed the dead code if you'd like to check again |
Contributor
|
🎬 CLI E2E Test Recordings — 52 recordings uploaded (commit View recordings
📹 Recordings uploaded automatically from CI run #23322032727 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Shortens install-script download logging so the Bash and PowerShell installers stop printing full download URLs.
The scripts now derive compact descriptors from the existing URL structure and emit messages like
Downloading aspire-cli-win-x64.zip from 'rc/daily'instead of echoing the raw URL. This applies to both CLI archive downloads and VS Code extension downloads, and also updates related dry-run /-WhatIfpaths so they no longer surface the full URL through script messaging.No dependencies are required for this change.
Validation:
pwsh -NoProfile -File .\eng\scripts\get-aspire-cli.ps1 -WhatIf -Quality staging -OS win -Architecture x64pwsh -NoProfile -File .\eng\scripts\get-aspire-cli.ps1 -WhatIf -Quality dev -OS win -Architecture x64 -InstallExtensionC:\Program Files\Git\bin\bash.exe eng/scripts/get-aspire-cli.sh --dry-run --quality staging --os win --arch x64C:\Program Files\Git\bin\bash.exe eng/scripts/get-aspire-cli.sh --dry-run --quality dev --os win --arch x64 --install-extensionFixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: