Fix default NuGet packages restore folder by eerhardt · Pull Request #15416 · microsoft/aspire

eerhardt · 2026-03-20T00:28:16Z

We shouldn't default to ~/.nuget/packages. Instead we should use NuGet defaulting logic.

Refactor the restore code using the patterns from the NuGet.Client sources. This simplifies the code.

github-actions · 2026-03-20T00:28:23Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15416

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15416"

eerhardt · 2026-03-20T00:28:41Z

/backport to release/13.2

github-actions · 2026-03-20T00:28:49Z

Started backporting to release/13.2: https://github.com/dotnet/aspire/actions/runs/23323572778

Copilot

Pull request overview

Updates RestoreCommand to use NuGet’s built-in settings resolution for the global packages folder instead of hard-coding ~/.nuget/packages, aligning behavior with NuGet defaults and config.

Changes:

Replace hard-coded user-profile-based packages folder with NuGet settings-based resolution.
Load NuGet configuration settings and compute the global packages folder via SettingsUtility.

src/Aspire.Managed/NuGet/Commands/RestoreCommand.cs

github-actions · 2026-03-20T00:53:06Z

Re-running the failed jobs in the CI workflow for this pull request because 3 jobs were identified as retry-safe transient failures in the CI run attempt.
GitHub was asked to rerun all failed jobs for that attempt, and the rerun is being tracked in the rerun attempt.
The job links below point to the failed attempt jobs that matched the retry-safe transient failure rules.

Tests / Npgsql / Npgsql (ubuntu-latest) - Failed step 'Build test project' will be retried because the job log shows a likely transient infrastructure network failure. Matched pattern: /Unable to load the service index for source https:\/\/(?:pkgs\.dev\.azure\.com\/dnceng|dnceng\.pkgs\.visualstudio\.com)\/public\/_packaging\//i.
Tests / Microsoft.EntityFrameworkCore.Cosmos / Microsoft.EntityFrameworkCore.Cosmos (ubuntu-latest) - Failed step 'Build test project' will be retried because the job log shows a likely transient infrastructure network failure. Matched pattern: /Unable to load the service index for source https:\/\/(?:pkgs\.dev\.azure\.com\/dnceng|dnceng\.pkgs\.visualstudio\.com)\/public\/_packaging\//i.
Tests / Dashboard / Dashboard (ubuntu-latest) - Failed step 'Build test project' will be retried because the job log shows a likely transient infrastructure network failure. Matched pattern: /Unable to load the service index for source https:\/\/(?:pkgs\.dev\.azure\.com\/dnceng|dnceng\.pkgs\.visualstudio\.com)\/public\/_packaging\//i.

We shouldn't default to ~/.nuget/packages. Instead we should use NuGet defaulting logic. Fix microsoft#15399 Fix microsoft#15404

Simplify the code to use the same patterns as NuGet.Client sources.

joperezr · 2026-03-22T03:59:31Z

src/Aspire.Managed/NuGet/Commands/RestoreCommand.cs

            var noNugetOrg = parseResult.GetValue(noNugetOrgOption);
            var verbose = parseResult.GetValue(verboseOption);

-            // Validate that both nuget-config and sources aren't provided together


Why did we decide to change the behavior here? Not sure I follow.

joperezr · 2026-03-22T04:13:24Z

src/Aspire.Managed/NuGet/Commands/RestoreCommand.cs

-            var packageSources = LoadPackageSources(sources, nugetConfigPath, workingDir, noNugetOrg, verbose);
+            // Resolve the default packages path from settings (env var, config, or ~/.nuget/packages).
+            // If --packages-dir is provided, RestoreArgs.GlobalPackagesFolder overrides this.
+            var defaultPackagesPath = SettingsUtility.GetGlobalPackagesFolder(settings);


NIT: Above we are printing packagesDir for verbose logging but we are not printing defaultPackagesPath which will be the one we want most of the time.

joperezr · 2026-03-22T04:14:33Z

src/Aspire.Managed/NuGet/Commands/RestoreCommand.cs

                AllowNoOp = false,
-                GlobalPackagesFolder = packagesDir
+                GlobalPackagesFolder = packagesDir,
+                MachineWideSettings = new XPlatMachineWideSetting(),


NIT: I believe you call this above, so perhaps we can just reuse.

joperezr · 2026-03-22T04:22:30Z

Left some minor feedback but this looks good otherwise.

Copilot AI review requested due to automatic review settings March 20, 2026 00:28

eerhardt requested review from davidfowl, joperezr and sebastienros March 20, 2026 00:28

github-actions bot mentioned this pull request Mar 20, 2026

[release/13.2] Fix default NuGet packages restore folder #15417

Merged

Copilot AI reviewed Mar 20, 2026

View reviewed changes

src/Aspire.Managed/NuGet/Commands/RestoreCommand.cs Outdated Show resolved Hide resolved

src/Aspire.Managed/NuGet/Commands/RestoreCommand.cs Outdated Show resolved Hide resolved

Copilot started reviewing on behalf of eerhardt March 20, 2026 00:37 View session

github-actions bot mentioned this pull request Mar 20, 2026

[pull requests] Review required #13834

Open

Fix default NuGet packages restore folder

6c9c83a

We shouldn't default to ~/.nuget/packages. Instead we should use NuGet defaulting logic. Fix microsoft#15399 Fix microsoft#15404

eerhardt force-pushed the FixNuGetRestorePackagesMain branch from 1ccd6b7 to 6c9c83a Compare March 20, 2026 21:40

Refactor how NuGet restore works.

4babf7d

Simplify the code to use the same patterns as NuGet.Client sources.

eerhardt requested a review from JamesNK March 20, 2026 22:57

joperezr closed this Mar 22, 2026

joperezr reopened this Mar 22, 2026

joperezr reviewed Mar 22, 2026

View reviewed changes

joperezr approved these changes Mar 22, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix default NuGet packages restore folder#15416

Fix default NuGet packages restore folder#15416
eerhardt wants to merge 2 commits intomicrosoft:mainfrom
eerhardt:FixNuGetRestorePackagesMain

eerhardt commented Mar 20, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 20, 2026 •

edited

Loading

Uh oh!

eerhardt commented Mar 20, 2026

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

joperezr Mar 22, 2026

Uh oh!

joperezr Mar 22, 2026

Uh oh!

joperezr Mar 22, 2026

Uh oh!

joperezr commented Mar 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

eerhardt commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eerhardt commented Mar 20, 2026

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

joperezr Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

joperezr Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

joperezr Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

joperezr commented Mar 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

eerhardt commented Mar 20, 2026 •

edited

Loading

github-actions bot commented Mar 20, 2026 •

edited

Loading