Fix Windows CLI backchannel socket path#15444
Merged
joperezr merged 2 commits intomicrosoft:release/13.2from Mar 20, 2026
Merged
Fix Windows CLI backchannel socket path#15444joperezr merged 2 commits intomicrosoft:release/13.2from
joperezr merged 2 commits intomicrosoft:release/13.2from
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15444Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15444" |
IEvangelist
approved these changes
Mar 20, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix how the Aspire CLI generates the backchannel “socket path” on Windows so the AppHost/CLI IPC channel is created in a consistent, CLI-managed location.
Changes:
- Removed the Windows-specific behavior that returned only the socket name (no directory) from
CliPathHelper.CreateSocketPath. - Made
CreateSocketPathalways create/use~/.aspire/cli/runtime/socketsand return a combined path.
When using named pipes for the Guest AppHost, we need to just return a name, not a path.
eerhardt
commented
Mar 20, 2026
| /// </summary> | ||
| /// <param name="socketPrefix">The socket file prefix.</param> | ||
| internal static string CreateSocketPath(string socketPrefix) | ||
| internal static string CreateUnixDomainSocketPath(string socketPrefix) |
Member
Author
There was a problem hiding this comment.
We should rename this
Suggested change
| internal static string CreateUnixDomainSocketPath(string socketPrefix) | |
| internal static string CreateBackChannelSocketPath(string socketPrefix) |
joperezr
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer impact
aspire rundoesn't work on Windows machines because we aren't fully qualifying the socket path.Testing
Manual
Regression
Yes, from previous build.