Unify non-Azure CLI E2E helpers and stabilize localhive#16131
Draft
Unify non-Azure CLI E2E helpers and stabilize localhive#16131
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 16131Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 16131" |
Convert all 35 remaining test files from DockerInstallMode to CliInstallStrategy. Remove SourceBuild-specific logic (local channel setup, bundle mounting, channel arguments) from TypeScriptPolyglotTests and TypeScriptSqlServerNativeAssetsBundleTests — LocalHive handles all of this via the archive. Verified locally: SmokeTests, TypeScriptStarterTemplate, and StartStopTests all pass with LocalHive mode. Fixes #16032 (partial) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
|
Let's make sure the deployment end to end tests don't regress. Right now we are down to 4 failing tests. 3 I hope will be fixed by #16125 and AcaCompactNamingUpgradeDeploymentTests, which I don't know why fails yet. 
|
davidfowl
force-pushed
the
davidfowl/unify-e2e-helpers
branch
from
8d78862 to
887df3f
Compare
eerhardt
reviewed
Apr 14, 2026
eerhardt
reviewed
Apr 14, 2026
eerhardt
reviewed
Apr 14, 2026
Drop the unrelated ReplaceText project swap from this PR and keep the existing script-based template version rewrite. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
eerhardt
reviewed
Apr 14, 2026
eerhardt
reviewed
Apr 14, 2026
eerhardt
reviewed
Apr 14, 2026
Use a shared socket-directory creation helper and switch the default short-path fallback to the platform temp root instead of hardcoding /tmp. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep the localhive and diagnostics improvements, but stop changing product socket path behavior. The E2E helpers now capture ~/.aspire artifacts into preserved workspaces instead of rewriting HOME. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
davidfowl
changed the title
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Migrate the non-Azure publish and deployment CLI E2E suites onto the shared install helpers and add a Podman-in-Docker helper image so Podman deploy validation no longer depends on host Podman state. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
davidfowl
changed the title
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🎬 CLI E2E Test Recordings — 71 recordings uploaded (commit View recordings
📹 Recordings uploaded automatically from CI run #24404068249 |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This draft consolidates the non-Azure CLI E2E helper migration with the localhive reliability fixes that fell out of validating real bundle-backed scenarios.
CliInstallStrategyand the shared terminal/install helpers..nupkgpath, improves process output draining with an idle-based forwarder wait, and filters AppleDouble._*package artifacts from localhive archives on macOS.Validation:
dotnet test tests/Aspire.Cli.Tests/Aspire.Cli.Tests.csproj -- --filter-not-trait "quarantined=true" --filter-not-trait "outerloop=true"dotnet test tests/Aspire.Cli.Tests/Aspire.Cli.Tests.csproj -- --filter-method "*.WaitForExitAsync_AllowsForwardersToDrainBeforeClosingStreams" --filter-method "*.SdkDumpCi_ForHostingProject_DoesNotEmitWarnings" --filter-not-trait "quarantined=true" --filter-not-trait "outerloop=true"ASPIRE_E2E_ARCHIVE=/tmp/aspire-stop-arm64-695e.tar.gz dotnet test tests/Aspire.Cli.EndToEnd.Tests/Aspire.Cli.EndToEnd.Tests.csproj -- --filter-method "*.DeployK8sBasicApiService" --filter-method "*.DeployTypeScriptAppToKubernetes" --filter-method "*.CreateAndDeployToDockerComposeWithPodman" --filter-not-trait "quarantined=true"Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?aspire.devissue: