Make the Email Report Extension Public (#34)

* Make the Email Report Extension Public

* use aliases for enableTLS

* Improve logging for retries

* Fix vars

* Fix icon size for marketplace reqs

Co-authored-by: Krishna V <[email protected]>

Author: saikrishnav

Tasks/emailReportTask/config/ConfigurationProvider.ts

@@ -78,7 +78,7 @@ export class ConfigurationProvider implements IConfigurationProvider {
     const smtpHost = tl.getEndpointUrl(smtpConnectionId, true).replace(/(^\w+:|^)\/\//, '').replace(/\/$/, '');
     const userName = tl.getEndpointAuthorizationParameter(smtpConnectionId, "UserName", true);
     const password = tl.getEndpointAuthorizationParameter(smtpConnectionId, "Password", true);
-    const enableTLS = tl.getBoolInput(TaskConstants.ENABLESSL_INPUTKEY, true);
+    const enableTLS = tl.getBoolInput(TaskConstants.ENABLETLS_INPUTKEY, true);
 
     const smtpConfig = new SmtpConfiguration(userName, password, smtpHost, enableTLS);
 

Tasks/emailReportTask/config/TaskConstants.ts

@@ -12,7 +12,9 @@ export class TaskConstants {
   public static readonly INCLUDEINTO_INPUTKEY = "includeInToSectionStr";
   public static readonly INCLUDEINCC_INPUTKEY = "includeInCcSectionStr";
   public static readonly SMTPCONNECTION_INPUTKEY = "smtpConnectionEndpoint";
-  public static readonly ENABLESSL_INPUTKEY = "enableSSLOnSmtpConnection";
+  // Inputkey value should be "enableTLS" - however changing that will break the task for everyone. See task.dev.json or task.prod.json for the confusion.
+  // For now -inputkey has to be enableSSL... until AzureDevOps marketplace supports a way to rename params in json
+  public static readonly ENABLETLS_INPUTKEY = "enableSSLOnSmtpConnection";
   public static readonly USEPREVENV_INPUTKEY = "usePreviousEnvironment";
   public static readonly DEFAULTDOMAIN_INPUTKEY = "defaultDomain";
 

Tasks/emailReportTask/images/icon.png

@@ -20,7 +20,7 @@ export class RetryablePromise {
                 }
                 catch (err) {
                     lastError = err;
-                    console.log(`Retry: ${attemptNumber} : ${err}`);
+                    console.log(`Retry <${executorName}>: ${attemptNumber} : ${err}`);
                 }
                 attemptNumber++;
             } while (attemptNumber <= times);

Tasks/emailReportTask/providers/restclients/RetryablePromise.ts

@@ -13,7 +13,7 @@
   "version": {
     "Major": 1,
     "Minor": 2,
-    "Patch": 204
+    "Patch": 208
   },
   "groups": [
     {
@@ -206,11 +206,14 @@
     },
     {
       "name": "enableSSLOnSmtpConnection",
+      "aliases": [
+        "enableTLS"
+      ],
       "type": "boolean",
-      "label": "Enable SSL",
+      "label": "Enable TLS",
       "required": false,
       "defaultValue": "false",
-      "helpMarkDown": "Enables SSL on SMTP Connection for sending email.",
+      "helpMarkDown": "Enables TLS on SMTP Connection for sending email.",
       "groupName": "advanced"
     },
     {

Tasks/emailReportTask/task.dev.json

@@ -13,7 +13,7 @@
   "version": {
     "Major": 1,
     "Minor": 1,
-    "Patch": 6
+    "Patch": 8
   },
   "groups": [
     {
@@ -206,11 +206,14 @@
     },
     {
       "name": "enableSSLOnSmtpConnection",
+      "aliases": [
+        "enableTLS"
+      ],
       "type": "boolean",
-      "label": "Enable SSL",
+      "label": "Enable TLS",
       "required": false,
       "defaultValue": "false",
-      "helpMarkDown": "Enables SSL on SMTP Connection for sending email.",
+      "helpMarkDown": "Enables TLS on SMTP Connection for sending email.",
       "groupName": "advanced"
     },
     {

Tasks/emailReportTask/task.prod.json

@@ -2,14 +2,15 @@
   "manifestVersion": 1,
   "id": "EmailReportExtension",
   "name": "Email Report Extension",
-  "version": "1.1.6",
+  "version": "1.1.9",
   "publisher": "epsteam",
+  "public": true,
   "targets": [
     {
       "id": "Microsoft.VisualStudio.Services"
     }
   ],
-  "description": "Extension to send a detailed email report for a build or release pipeline",
+  "description": "Sends Detailed email report for a build or release pipeline",
   "categories": [
     "Azure Pipelines"
   ],
@@ -35,6 +36,10 @@
       "path": "LICENSE"
     }
   },
+  "repository": {
+    "type": "git",
+    "uri": "https://github.com/microsoft/azure-devops-engineering-extensions"
+  },
   "contributions": [
     {
       "id": "EmailReport",