feat: Add Interactive Browser Credential as a fallback #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Try all credentials in sequence --> Azure CLI (if tenantID given), Default, then Interactive - Removed ChainedTokenCredential as it fails if Azure CLI is not installed on client's machine - Tested the different auth mechanisms locally
kboom
reviewed
Jul 18, 2025
|
|
||
| // Try DefaultAzureCredential first (includes managed identity, environment variables, etc.) | ||
| try { | ||
| const defaultCredential = new DefaultAzureCredential(); // CodeQL [SM05138] resolved by explicitly setting AZURE_TOKEN_CREDENTIALS |
There was a problem hiding this comment.
But this will bring back CodeQL warning?
There was a problem hiding this comment.
Hi @kboom,
The comment indicated that the fix for the warning is to explicitly set the environment variable AZURE_TOKEN_CREDENTIALS, which we are doing on lines 42-46.
I could not find any references on that particular warning [SM05138] on the internet, so not sure about its contents/reasons/fixes.
|
Closing the pull request, as it is against the contributor guidelines to contribute to an unapproved issue. |
|
@microsoft-github-policy-service agree company="Microsoft" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#306
Associated Risks
✅ PR Checklist
🧪 How did you test it?
Locally used the server with and without the Azure CLI installed.