-
Notifications
You must be signed in to change notification settings - Fork 191
feat: Add Interactive Browser Credential as a fallback #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
srathi-msft
wants to merge
5
commits into
microsoft:main
from
srathi-msft:feat/interactive-credential-fallback
Closed
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d9c8d4d
feat: Add Interactive Browser Credential as a fallback
srathi-msft bd2ea37
chore: Formatting changes
srathi-msft 0aa1dd0
chore: Update README.md
srathi-msft ed471fd
Merge branch 'main' into feat/interactive-credential-fallback
srathi-msft 9d4311e
Merge branch 'main' into feat/interactive-credential-fallback
kboom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this will bring back CodeQL warning?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kboom,
The comment indicated that the fix for the warning is to explicitly set the environment variable
AZURE_TOKEN_CREDENTIALS
, which we are doing on lines 42-46.I could not find any references on that particular warning [SM05138] on the internet, so not sure about its contents/reasons/fixes.